Date: Wed, 6 Dec 2023 19:59:22 -0800 From: "Simon J. Gerraty" <sjg@juniper.net> To: Warner Losh <imp@bsdimp.com> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org>, <sjg@juniper.net> Subject: Re: git: 83d0b8c089d8 - main - bsdinstall generate opt_osname.h in include Message-ID: <71239.1701921562@kaos.jnpr.net> In-Reply-To: <CANCZdfpm=GD5_5tf3LCrhVWcv95jb86mj23JEAX=2dsKyJQ5rQ@mail.gmail.com> References: <202312070235.3B72ZoZp043061@gitrepo.freebsd.org> <CANCZdfpm=GD5_5tf3LCrhVWcv95jb86mj23JEAX=2dsKyJQ5rQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh <imp@bsdimp.com> wrote:
> Silly question: why not just add it to CFLAGS with
> -DOSNAME=\"${OSNAME}\" rather than generating this file?
Actually it is an excellent question - I've no idea why opt_osname.h is
needed.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?71239.1701921562>