Date: Fri, 15 Jan 2010 22:30:03 GMT From: Maxim Zakharov <maxime@maxime.net.ru> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/141682: [libc] [patch] Faster version of strncpy(3) Message-ID: <201001152230.o0FMU3KY071140@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/141682; it has been noted by GNATS.
From: Maxim Zakharov <maxime@maxime.net.ru>
To: Jaakko Heinonen <jh@freebsd.org>
Cc: bug-followup@freebsd.org
Subject: Re: kern/141682: [libc] [patch] Faster version of strncpy(3)
Date: Sat, 16 Jan 2010 01:26:03 +0300
Hi,
if (length) {
register size_t n = length / 8;
register size_t r = (length % 8);
register char *dst = dst0, *src = src0;
if (r == 0) r = 8; else n++;
this solves the problem.
Thank you.
On 1/15/10, Jaakko Heinonen <jh@freebsd.org> wrote:
>
> Hi,
>
> On 2009-12-17, Maxim Zakharov wrote:
>> void * dps_strncpy(char *dst0, char *src0, size_t length) {
>> if (length) {
>> register size_t n = (length + 7) / 8;
>
> This won't work with length values larger than SIZE_MAX - 7 due to
> integer overflow.
>
> --
> Jaakko
>
--
http://www.dataparksearch.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001152230.o0FMU3KY071140>