Date: Wed, 30 Apr 2003 18:43:51 -0400 From: Mike Barcroft <mike@FreeBSD.org> To: Mark Murray <markm@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 identcpu.c Message-ID: <20030430184351.B31859@espresso.bsdmike.org> In-Reply-To: <200304301223.h3UCNwOW056381@repoman.freebsd.org>; from markm@FreeBSD.org on Wed, Apr 30, 2003 at 05:23:58AM -0700 References: <200304301223.h3UCNwOW056381@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Mark Murray <markm@FreeBSD.org> writes: > markm 2003/04/30 05:23:58 PDT > > FreeBSD src repository > > Modified files: > sys/i386/i386 identcpu.c > Log: > Warns fixing. Protect against inappropriate linting, and mark > GCC-specific assemble code as such (in #ifdefs). Fix an easy > static variable warning while I'm here. > > Revision Changes Path > 1.122 +8 -1 src/sys/i386/i386/identcpu.c Is it really useful to #ifdef critical sections of code. This thing isn't going to compile without asm extentions from the compiler. So really you just turn compile errors into link error. Not very helpful IMO. Also, you added an used #else clause near the top. Best regards, Mike Barcroft
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030430184351.B31859>