Date: Fri, 17 Dec 2010 12:58:34 -0800 From: Doug Barton <dougb@FreeBSD.org> To: "Philip M. Gollucci" <pgollucci@FreeBSD.org> Cc: janos.mohacsi@bsd.hu, cvs-ports@FreeBSD.org, Craig Leres <leres@ee.lbl.gov>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/beacon Makefile ports/net/beacon/files beacon.in patch-Makefile.in patch-common-beacon.patch patch-libbeacon-Makefile.in Message-ID: <4D0BCEFA.1030305@FreeBSD.org> In-Reply-To: <201012152244.oBFMigGD066775@repoman.freebsd.org> References: <201012152244.oBFMigGD066775@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Couple of problems with this script. First, since by default it is now
running as a non-root user it should REQUIRE: LOGIN. We prefer not to
run code unconditionally, so the if [ -f ${config} ] block should
probably be in a prestart method. Finally the traditional way of
daemoninzing is to make command /usr/sbin/daemon, and command_args
include the thing to start. There are numerous examples of this, it
should not be too hard to find one.
hth,
Doug
On 12/15/2010 14:44, Philip M. Gollucci wrote:
> pgollucci 2010-12-15 22:44:42 UTC
>
> FreeBSD ports repository
>
> Modified files:
> net/beacon Makefile
> net/beacon/files beacon.in
> Added files:
> net/beacon/files patch-Makefile.in
> patch-common-beacon.patch
> patch-libbeacon-Makefile.in
> Log:
> - Unbreak on !i386
> - rc.d script handle daemonize and run as nobody by default
> - Bump PORTREVISION
>
> PR: ports/149127 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=149127
> Submitted by: Craig Leres<leres@ee.lbl.gov>
> Approved by: janos.mohacsi@bsd.hu (maintainer)
>
> Revision Changes Path
> 1.22 +5 -11 ports/net/beacon/Makefile
> 1.3 +29 -11 ports/net/beacon/files/beacon.in
> 1.1 +11 -0 ports/net/beacon/files/patch-Makefile.in (new)
> 1.1 +18 -0 ports/net/beacon/files/patch-common-beacon.patch (new)
> 1.1 +11 -0 ports/net/beacon/files/patch-libbeacon-Makefile.in (new)
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/beacon/Makefile.diff?&r1=1.21&r2=1.22&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/beacon/files/beacon.in.diff?&r1=1.2&r2=1.3&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/beacon/files/patch-Makefile.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/beacon/files/patch-common-beacon.patch
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/beacon/files/patch-libbeacon-Makefile.in
>
--
Nothin' ever doesn't change, but nothin' changes much.
-- OK Go
Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D0BCEFA.1030305>