Date: Wed, 21 Feb 2018 18:46:39 +0000 From: Colin Percival <cperciva@tarsnap.com> To: Benno Rice <benno@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329737 - head/stand/i386/boot2 Message-ID: <01000161b9b05f85-2dd39c19-942a-40de-8ad5-991d2c9c7000-000000@email.amazonses.com> In-Reply-To: <201802211810.w1LIApvC012656@repo.freebsd.org> References: <201802211810.w1LIApvC012656@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 02/21/18 10:10, Benno Rice wrote:
> Curiously, changing whitespace seems to cause the md5 of the .o files to differ
> these days hence the following testing strategy:
>
> Tested by: objdump -d | md5 (both in-tree clang and lang/gcc6)
Is this simply because line numbers are changing? That isn't new; I remember
a case where a security advisory touched a .h file and suddenly a huge number
of binaries changed because they included header file line numbers.
> static inline int
> strcmp(const char *s1, const char *s2)
> {
> - for (; *s1 == *s2 && *s1; s1++, s2++);
> - return (unsigned char)*s1 - (unsigned char)*s2;
> +
> + for (; *s1 == *s2 && *s1; s1++, s2++);
> + return (unsigned char)*s1 - (unsigned char)*s2;
> }
--
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01000161b9b05f85-2dd39c19-942a-40de-8ad5-991d2c9c7000-000000>