Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 25 Oct 2005 21:12:07 +0400
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        Max Laier <max@love2party.net>
Cc:        Pete French <petefrench@ticketswitch.com>, freebsd-stable@FreeBSD.org, csjp@FreeBSD.org, Vladimir Sharun <sharun@ukr.net>, Kris Kennaway <kris@obsecurity.org>
Subject:   Re: kmem_malloc(4096): kmem_map too small: 536870912 total allocated
Message-ID:  <20051025171207.GQ41520@cell.sick.ru>
In-Reply-To: <200510251804.37929.max@love2party.net>
References:  <20051023074342.GA97095@dun.ukr.net> <20051025150018.GO41520@cell.sick.ru> <200510251804.37929.max@love2party.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 25, 2005 at 06:04:15PM +0200, Max Laier wrote:
M> On Tuesday 25 October 2005 17:00, Gleb Smirnoff wrote:
M> >   Vladimir,
M> >
M> >   please confirm that the attached patch fix your problem. The patch is
M> > relative to src/sys tree.
M> >
M> >   Kris, Christian, please review it. Thanks.
M> 
M> Are you sure it's safe to free the nlminfo struct before calling to fdfree() 
M> in exit1()?  It sounds like it might need the structure if there are pending 
M> locks?  Just a guess, though.

The locks are actually held on the server side, so we aren't leaking
them here. Anyway, the fix is directly from BSD/OS, from where
nlminfo have came from.

M> On a side note, there are some whitespace errors in and before 
M> nlminfo_release().

Thanks. I'll take this into account.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051025171207.GQ41520>