Date: Mon, 30 May 2005 12:10:56 +0900 (JST) From: KIYOHARA Takashi <kiyohara@kk.iij4u.or.jp> To: freebsd-current@freebsd.org Cc: kiyohara@kk.iij4u.or.jp Subject: fwcontrol patch Message-ID: <20050530.121056.74739774.kiyohara@kk.iij4u.or.jp>
next in thread | raw e-mail | index | archive | help
----Next_Part(Mon_May_30_12:10:56_2005_364)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Hi! all.
I request to change for usr.sbin/fwcontrol/fwcontrol.c.
1. Return value of sysctl_set_int() is int. But no return.
2. indent miss in main().
Thanks
--
kiyohara
----Next_Part(Mon_May_30_12:10:56_2005_364)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="fwcontrol.c.diff"
--- fwcontrol.c.orig 2005-05-30 11:56:26.000000000 +0900
+++ fwcontrol.c 2005-05-30 11:56:38.000000000 +0900
@@ -608,6 +608,7 @@
{
if (sysctlbyname(name, NULL, NULL, &val, sizeof(int)) < 0)
err(1, "sysctl %s failed.", name);
+ return (0);
}
int
@@ -655,8 +656,8 @@
show_crom(crom_buf);
break;
case 'm':
- if (eui64_hostton(optarg, &target) != 0 &&
- eui64_aton(optarg, &target) != 0)
+ if (eui64_hostton(optarg, &target) != 0 &&
+ eui64_aton(optarg, &target) != 0)
errx(1, "invalid target: %s", optarg);
eui.hi = ntohl(*(u_int32_t*)&(target.octet[0]));
eui.lo = ntohl(*(u_int32_t*)&(target.octet[4]));
----Next_Part(Mon_May_30_12:10:56_2005_364)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050530.121056.74739774.kiyohara>