Date: Sat, 21 Jun 2003 06:33:41 -0700 From: Hiten Pandya <hmp@FreeBSD.ORG> To: Sean Kelly <smkelly@zombie.org> Cc: freebsd-current@Freebsd.org Subject: Re: Software watchdog patch Message-ID: <20030621133341.GC6558@perrin.int.nxad.com> In-Reply-To: <20030621024707.GA73447@edgemaster.zombie.org> References: <20030621024707.GA73447@edgemaster.zombie.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 20, 2003 at 09:47:07PM -0500, Sean Kelly wrote: > Greetings. > I look forward to any feedback, whether positive or negative. Hello Sean, this stuff looks really promising. Anyways, I can't comment about the code as I have had no time to read it, but here are a few mdoc nitpicks I did: =09 Index: share/man/man4/watchdog.4 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D +is implemented via a trio of sysctl OIDs. When +.Va debug.watchdog.enabled Hmm, the .Va should be replaced with .Li. Also, it is necessary to remove all hard sentence breaks, ie. instead of: "via a trio of sysctl OIDs. When..." =09 It should be: "via a trio of sysctl OIDs. When..." =09 Sysctls should be documented using .Li. +.Sh SEE ALSO +.Xr watchdogd 8 , +.Xr sysctl 8 +.Sh HISTORY Manual pages are first ordered by their section numbers, and then alphabetically, thus watchdogd(8)'s .Xr should be after sysctl(8). =09 +.Sh AUTHORS +.An -nosplit +The +.Nm +code and man page were written by +.An Sean Kelly Aq smkelly@zombie.org . Use `manual page' instead of `man page'. =09 Same sort of comments apply to the watchdogd(8) manual page. Hope that helps. Cheers. -- Hiten (hmp@FreeBSD.ORG)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030621133341.GC6558>