Date: Sat, 24 Oct 2009 18:49:18 +0000 (UTC) From: Ruslan Ermilov <ru@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r198448 - in head/sys: fs/smbfs netgraph Message-ID: <200910241849.n9OInIvI005409@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ru Date: Sat Oct 24 18:49:17 2009 New Revision: 198448 URL: http://svn.freebsd.org/changeset/base/198448 Log: Spell DIAGNOSTIC correctly. Modified: head/sys/fs/smbfs/smbfs_vfsops.c head/sys/netgraph/NOTES Modified: head/sys/fs/smbfs/smbfs_vfsops.c ============================================================================== --- head/sys/fs/smbfs/smbfs_vfsops.c Sat Oct 24 18:38:24 2009 (r198447) +++ head/sys/fs/smbfs/smbfs_vfsops.c Sat Oct 24 18:49:17 2009 (r198448) @@ -259,7 +259,7 @@ smbfs_mount(struct mount *mp) VOP_UNLOCK(vp, 0); SMBVDEBUG("root.v_usecount = %d\n", vrefcnt(vp)); -#ifdef DIAGNOSTICS +#ifdef DIAGNOSTIC SMBERROR("mp=%p\n", mp); #endif return error; Modified: head/sys/netgraph/NOTES ============================================================================== --- head/sys/netgraph/NOTES Sat Oct 24 18:38:24 2009 (r198447) +++ head/sys/netgraph/NOTES Sat Oct 24 18:49:17 2009 (r198448) @@ -76,10 +76,10 @@ Archie's suggestions... :-) be careful with things like #ifdef INET. - All nodes assume that all data mbufs have the M_PKTHDR flag set! The ng_send_data() and related functions should have an - #ifdef DIAGNOSTICS check to check this assumption for every mbuf. + #ifdef DIAGNOSTIC check to check this assumption for every mbuf. -DONE with INVARIANTS. Framework should test this more. - More generally, netgraph code should make liberal use of the - #ifdef DIAGNOSTICS definition. + #ifdef DIAGNOSTIC definition. -INVARIANTS. - Since data and messages are sent functionally, programmers need to watch out for infinite feedback loops. Should ng_base.c detect
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200910241849.n9OInIvI005409>