Date: Thu, 7 Dec 2023 04:03:29 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: Warner Losh <imp@bsdimp.com>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 83d0b8c089d8 - main - bsdinstall generate opt_osname.h in include Message-ID: <D51E0060-60C3-4D56-96C5-B51F1D07DD6C@freebsd.org> In-Reply-To: <71239.1701921562@kaos.jnpr.net> References: <202312070235.3B72ZoZp043061@gitrepo.freebsd.org> <CANCZdfpm=GD5_5tf3LCrhVWcv95jb86mj23JEAX=2dsKyJQ5rQ@mail.gmail.com> <71239.1701921562@kaos.jnpr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7 Dec 2023, at 03:59, Simon J. Gerraty <sjg@juniper.net> wrote:
> Warner Losh <imp@bsdimp.com> wrote:
>> Silly question: why not just add it to CFLAGS with
>> -DOSNAME=3D\"${OSNAME}\" rather than generating this file?
>=20
> Actually it is an excellent question - I've no idea why opt_osname.h =
is
> needed.
To quote the motivation from brd@=E2=80=99s original review:
> The reason I did it using a file is so that make(1) would detect a
> change a rebuild if you change the value and do another build.
-- https://reviews.freebsd.org/D34878#791429
Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D51E0060-60C3-4D56-96C5-B51F1D07DD6C>