Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 1 Nov 2007 01:37:27 +0300
From:      Andrey Chernov <ache@nagual.pp.ru>
To:        Alexey Dokuchaev <danfe@FreeBSD.ORG>
Cc:        cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, Juli Mallett <juli@clockworksquid.com>, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/include _ctype.h
Message-ID:  <20071031223727.GB90994@nagual.pp.ru>
In-Reply-To: <20071031223349.GA552@FreeBSD.org>
References:  <200710272232.l9RMWSbK072082@repoman.freebsd.org> <20071030200331.GA29309@toxic.magnesium.net> <20071031215526.GC89932@nagual.pp.ru> <20071031223349.GA552@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 31, 2007 at 10:33:49PM +0000, Alexey Dokuchaev wrote:
> > For ones who doubts there two tests compiled with -O2. As you may see the 
> > result is almost identical (andl vs cmpl):
> 
> Q.E.D.  How about to restore original, more reader-friendly version then?

1. Reader-friendly version generates long code when absolutely no 
optimization used in compiler (for some reason f.e. to avoid optimization 
bugs).

2. It also breaks common style ctype using for is{w}ascii(). If revert 
this, is{w}ascii() should be rewritted too.

-- 
http://ache.pp.ru/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071031223727.GB90994>