Date: Wed, 12 Jun 2013 21:31:56 +0300 From: Alexander Motin <mav@FreeBSD.org> To: Dimitry Andric <dim@FreeBSD.org> Cc: svn-src-head@freebsd.org, Glen Barber <gjb@FreeBSD.org>, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r251654 - in head/sys: cam cam/scsi geom Message-ID: <51B8BE9C.7070301@FreeBSD.org> In-Reply-To: <CA6AD904-41B9-48C9-841A-9BA8A61C98B4@FreeBSD.org> References: <201306121336.r5CDaKUF007665@svn.freebsd.org> <CA6AD904-41B9-48C9-841A-9BA8A61C98B4@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12.06.2013 21:29, Dimitry Andric wrote: > On Jun 12, 2013, at 15:36, Alexander Motin <mav@FreeBSD.org> wrote: >> Author: mav >> Date: Wed Jun 12 13:36:20 2013 >> New Revision: 251654 >> URL: http://svnweb.freebsd.org/changeset/base/251654 >> >> Log: >> Make CAM return and GEOM DISK pass through new GEOM::lunid attribute. >> >> SPC-4 specification states that serial number may be property of device, >> but not a specific logical unit. People reported about FC storages using >> serial number in that way, making it unusable for purposes of LUN multipath >> detection. SPC-4 states that designators associated with logical unit from >> the VPD page 83h "Device Identification" should be used for that purpose. >> Report first of them in the new attribute in such preference order: NAA, >> EUI-64, T10 and SCSI name string. >> >> While there, make GEOM DISK properly report GEOM::ident in XML output also >> using d_getattr() method, if available. This fixes serial numbers reporting >> for SCSI disks in `geom disk list` output and confxml. >> >> Discussed with: gibbs, ken >> Sponsored by: iXsystems, Inc. >> MFC after: 2 weeks > > This prototype change breaks head: > > cc -O2 -pipe -DRESCUE -std=gnu99 -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wmissing-variable-declarations -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c /src/sbin/camcontrol/camcontrol.c > /src/sbin/camcontrol/camcontrol.c:6955:13: error: incompatible pointer types assigning to 'uint8_t *' (aka 'unsigned char *') from 'struct scsi_vpd_id_descriptor *' [-Werror,-Wincompatible-pointer-types] > item_addr = scsi_get_devid(item->device_id, > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Thank you for your reports, already testing fix. I'm sorry. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51B8BE9C.7070301>