Date: Fri, 21 Dec 2001 01:46:50 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: Peter Wemm <peter@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/alpha/alpha pmap.c src/sys/i386/i386 pmap.csrc/sys/ia64/ia64 pmap.c Message-ID: <20011221014329.O1630-100000@gamplex.bde.org> In-Reply-To: <3C21F2F1.542EE5CC@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 20 Dec 2001, Maxim Sobolev wrote:
> > On Wed, 19 Dec 2001, Peter Wemm wrote:
> > >...
> > > Replace a bunch of:
> > > for (pv = TAILQ_FIRST(&m->md.pv_list);
> > > pv;
> > > pv = TAILQ_NEXT(pv, pv_list)) {
> > > with:
> > > TAILQ_FOREACH(pv, &m->md.pv_list, pv_list) {
> > >...
> > This is a regression IMO. Please write C programs in something
> > resembling C.
>
> Why then we have all those *_FOREACH macros in sys/queue.h?
Opinions differ, and mine aren't quite strong enough to back out the
commit that added *_FOREACH.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011221014329.O1630-100000>