Date: Tue, 10 Feb 2009 08:27:57 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Eugene Grosbein <eugen@kuzbass.ru> Cc: stable@freebsd.org Subject: Re: sysctl lock in RELENG_6 Message-ID: <20090210062757.GK9427@deviant.kiev.zoral.com.ua> In-Reply-To: <20090210040125.GA80054@svzserv.kemerovo.su> References: <498FAA2A.7423AC15@kuzbass.ru> <20090209214822.GH9427@deviant.kiev.zoral.com.ua> <20090210040125.GA80054@svzserv.kemerovo.su>
next in thread | previous in thread | raw e-mail | index | archive | help
--J3rqiH0DIeiRD2zz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 10, 2009 at 11:01:25AM +0700, Eugene Grosbein wrote: > On Mon, Feb 09, 2009 at 11:48:22PM +0200, Kostik Belousov wrote: >=20 > > > I've digged commit logs a bit and found this change MFC'd to RELENG_7 > > > but not RELENG_6: > > >=20 > > > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/kern/kern_sysctl.c#rev1= .177.6.2 > > >=20 > > > It seems RELENG_6 needs this too, doesn't it? > > > I'm going to merge the change to RELENG_6 and give it a try. > >=20 > > Yes, please give it a try. In fact, it was quite specific situation > > that I observed and produced a fix for. You need execing process that > > needs to grab Giant, e.g. due to image being located on !MPSAFE fs, and > > simultaneous sysctl issued that inspects this process. >=20 > Well, my 6.3-STABLE locked very often (sometimes every hour). > Yesterday I've upgraded it to 6.4-STABLE, applied 1.177.2.1 of the file > to sources, rebuilt NanoBSD image and ran it. It has not locked yet. Can you be slightly more scientific in your tests ? Try RELENG_6 without my patch to see whether it is needed at all. >=20 > Btw, root filesystem here is UFS2 without softupdates mounted read-only > but /etc and /var are md(4) (devfs is mounted too). >=20 > Eugene Grosbein --J3rqiH0DIeiRD2zz Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkmRHmsACgkQC3+MBN1Mb4idjgCeM2VBjzFz3km/3vsOt4w/qGXF U/UAn30OB6pjq2UMzy4oZSfFab+Oq8Qs =ZJzE -----END PGP SIGNATURE----- --J3rqiH0DIeiRD2zz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090210062757.GK9427>