Date: Fri, 14 Apr 2017 19:36:55 -0700 From: Peter Wemm <peter@wemm.org> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: Maxim Sobolev <sobomax@sippysoft.com>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Hiren Panchasara <hiren@freebsd.org>, Hiroki Sato <hrs@freebsd.org> Subject: Re: svn commit: r316874 - head/sys/kern Message-ID: <13691757.t3s7Qik7v1@overcee.wemm.org> In-Reply-To: <C976394B-87C9-40E5-A66D-951B77D7982D@gmail.com> References: <201704141723.v3EHNS3B043902@repo.freebsd.org> <CAH7qZfvPQpmTkypWdv1K=9yKF6was1sXuXY7McAeTrC8mvYZbg@mail.gmail.com> <C976394B-87C9-40E5-A66D-951B77D7982D@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Friday, April 14, 2017 02:14:16 PM Ngie Cooper wrote: > > On Apr 14, 2017, at 14:10, Maxim Sobolev <sobomax@sippysoft.com> wrote: > > > > Peter, Ngie, > > > > Looks like out of that refactoring came a logical bug that is present in > > the head, which causes syslod to first to shutdown the socket for reading > > and then try to select/recv on it (which is somewhat stupid). And that > > issue has been masked by shutdown() on datagram socket becoming > > effectively a NOP in 11 & head 20 months ago. It only affects head > > though, 11-stable still has the old code which does not include that > > half-closed socket into the select list. Attached patch is expected to > > fix head, Peter, it would be nice if you can give it a try (restoring > > latest changes into uipc_sockets.c) and let me know if it helps. > > > > Thanks! > > CCing hrs@ for input as he did the refactoring. > Thanks! > -Ngie > > PS LGTM with the change. Will wait for feedback from wemm@. This is definitely not working. I get ENOSPC and listen queue overflows on /var/run/logpriv now. Grabbing an old 10.3 /usr/sbin/syslogd and placing it on the top of the 12.x one worked fine, aside from the include statements. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV UTF-8: for when a ' or ... just won\342\200\231t do\342\200\246 [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEBgrA0Vr/vfNVuPoUNdaXCeyAngQFAljxh0cACgkQNdaXCeyA ngTMEAf/ZfGz2aGu0L9XPstos2TSqePLeyPsBf0RNANU3vhgbFcKQzLtIV0GXaKs rpadYtXEpunawlbe/vzz//BQU14Acf5v65YmMxjMS78ZEI2atalwAyZLLVKs2uRg ehTlq3mH0DaPi2E7Fd5BxdzNX3QsO6WC8cJ6QVKD4THNlCvYbyHANtBY31FUrKf1 a6UfWauFO1V0AVwhV6Ooj1SjRmGLpENSxFhs/dfieb6khE40V/aSnY7ngaGEBq8B eZZk/8p6K8gS4L1cBN/0BmVSCOkQvtD0jAdAJmbts2Qbk2hVGTjAsr+dr47jMPjG huf95KmoT3toCJvWLcQP3Iid/q/BmA== =HNXh -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13691757.t3s7Qik7v1>