Date: Thu, 25 Mar 2004 12:04:57 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Rafal Skoczylas <nils@secprog.org> Cc: freebsd-current@freebsd.org Subject: Re: [UFS] Broken suiddir? (+patch) Message-ID: <20040325110457.GX8930@darkness.comp.waw.pl> In-Reply-To: <20040325103222.GA7210@secprog.org> References: <20040323223020.GA2931@secprog.org> <20040324225318.GS8930@darkness.comp.waw.pl> <20040325103222.GA7210@secprog.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Thu, Mar 25, 2004 at 11:32:22AM +0100, Rafal Skoczylas wrote: +> On Wed, Mar 24, 2004 at 11:53:18PM +0100, Pawel Jakub Dawidek wrote: +> > +> - ucred.cr_uid = ip->i_uid; +> > +> + ucred.cr_uid = dp->i_uid; +> > +> > I haven't test your report and patch yet, but it is strange. +> > In line 1403 stays: +> > +> > ip->i_uid = dp->i_uid; +> > +> > So ip->i_uid should be equal in line which you have patched. +> +> Indeed, but somehow it wasn't. +> Hmm.. maybe I did some mistake when testing, but still this is +> quite strange as I asked a friend of mine to test it as well +> (on the same system tho) and we both had same results. +> Could anyone else try this? I've just tried and it works. Are you sure you have added +s bit on this directory? Even if there is no +s bit, group will be taken from parent directory for newly created file. Or maybe your file system isn't mounted with MNT_SUIDDIR flag? Try this: # mount -o suiddir /your_mount_point # chmod 4777 /your_mount_point/your_dir % touch /your_mount_point/your_dir/foo % ls -l /your_mount_point/your_dir/foo -- Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAYrzZForvXbEpPzQRAj1VAKC4tZRmcVFlZLXhwpJEiohsaTs0CwCgp9SA NYGxI1r1MhrTADZTjQPXOVE= =zeaJ -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040325110457.GX8930>