Date: Tue, 28 Dec 2010 15:32:47 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Ulrich Sp??rlein <uqs@spoerlein.net> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r216694 - head/libexec/rtld-elf Message-ID: <20101228133247.GR90883@deviant.kiev.zoral.com.ua> In-Reply-To: <20101228132942.GY23098@acme.spoerlein.net> References: <201012250842.oBP8gchA016800@svn.freebsd.org> <20101228132942.GY23098@acme.spoerlein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Dec 28, 2010 at 02:29:43PM +0100, Ulrich Sp??rlein wrote: > On Sat, 25.12.2010 at 08:42:38 +0000, Konstantin Belousov wrote: > > Author: kib > > Date: Sat Dec 25 08:42:38 2010 > > New Revision: 216694 > > URL: http://svn.freebsd.org/changeset/base/216694 > > > > Log: > > Add a hook to pass debug flags to the build of rtld when doing make in > > the rtld directory. > > > > Reviewed by: kan > > Please revert this, $(VAR) is against style, and passing DEBUG_FLAGS is > the canonical way to achieve what you wanted, eg. make DEBUG_FLAGS=-g is > working just fine for me. DEBUG_FLAGS=-g might be fine for you, but it does not do what rtld debugging needs. Look at the -DDEBUG. If you want ${} instead of $(), feel free to change. > > > Modified: > > head/libexec/rtld-elf/Makefile > > > > Modified: head/libexec/rtld-elf/Makefile > > ============================================================================== > > --- head/libexec/rtld-elf/Makefile Fri Dec 24 21:31:18 2010 (r216693) > > +++ head/libexec/rtld-elf/Makefile Sat Dec 25 08:42:38 2010 (r216694) > > @@ -34,7 +34,7 @@ CFLAGS+= -fPIC > > .else > > CFLAGS+= -fpic > > .endif > > -CFLAGS+= -DPIC > > +CFLAGS+= -DPIC $(DEBUG) > > LDFLAGS+= -shared -Wl,-Bsymbolic > > DPADD= ${LIBC_PIC} > > LDADD= -lc_pic -lssp_nonshared [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk0Z5v8ACgkQC3+MBN1Mb4gOpQCeI2xsxpg1y8F3WmoQFMqEl8bu hw4AoIveWcjohTdkYeJtV1rZTDm8X4Uk =npGo -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101228133247.GR90883>