Date: Wed, 26 Oct 2005 15:47:12 -0700 From: "David O'Brien" <obrien@freebsd.org> To: Roman Kurakin <rik@cronyx.ru> Cc: Roman Kurakin <rik@freebsd.org>, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: cvs commit: src/sys/dev/cp if_cp.c Message-ID: <20051026224712.GA16118@dragon.NUXI.org> In-Reply-To: <435FE099.6060508@cronyx.ru> References: <200509271657.j8RGvj2n015326@repoman.freebsd.org> <20051024072423.GA34909@dragon.NUXI.org> <200510241034.27073.jhb@freebsd.org> <20051025052018.GE55418@dragon.NUXI.org> <435E04AA.3080605@cronyx.ru> <20051026172734.GA99901@dragon.NUXI.org> <435FE099.6060508@cronyx.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 27, 2005 at 12:01:29AM +0400, Roman Kurakin wrote: > David O'Brien: > >On Tue, Oct 25, 2005 at 02:10:50PM +0400, Roman Kurakin wrote: > >>The commit log didn't state what was the problem variable forward > >>declaration or/and function > >>forward declaration. > > > >Since you became a committer 2003/12/18, I guess you haven't been part of > >FreeBSD when we've worked on a GCC compiler upgrade. We make these type > >of changes to make a new version of GCC build FreeBSD. The other choice > >is to disconnect these drivers from the build. The commits done where > >typical of what's been done for the past decade. > > > Please provide detailed technical information what is wrong in my > change of your commit. Instead of arguing this with you as it is probably fruitless. If you're going to pull the "maintainer" card, then please have these drivers moved to src/sys/contrib and note them in src/MAINTAINERS. That way this isn't a landmine for other committers to step on. > I do not want to list them in src/MAINTAINERS cause I think it is > better to allow any commits. > Cases such this one is rare. Rare or not, they can occur so why not take easy steps to avoid strife? -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051026224712.GA16118>