Date: Thu, 26 Jun 2003 11:40:23 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Scott Long <scottl@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/ips ips.c ips.h ips_commands.c ips_pci.c Message-ID: <XFMail.20030626114023.jhb@FreeBSD.org> In-Reply-To: <200306260003.h5Q03xUj002309@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26-Jun-2003 Scott Long wrote:
> scottl 2003/06/25 17:03:59 PDT
>
> FreeBSD src repository
>
> Modified files:
> sys/dev/ips ips.c ips.h ips_commands.c ips_pci.c
> Log:
> - Zero the buffers used to hold configuration data from the card. Not doing
> so can leave stale data in the buffer and confuse the driver.
> - enable the ability to set the 'disable' hint for the driver to keep it
> from attaching. i.e. 'hw.ips.0.disable=1' will prevent the driver from
> attaching.
Should be "hint.ips.0.disabled". Perhaps we need to add a resource_disabled()
function to abstract this so people stop getting it wrong. Something like:
int
resource_disabled(const char *name, int unit)
{
int error, value;
value = resource_int_value(name, unit, "disabled", &error);
if (error == 0)
return (value);
return (0);
}
You could then expand this function to check 'disable' as well if
desired and allow for 'true' and 'false', 'on' and 'off' in addition
to '0' and '1'.
--
John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030626114023.jhb>