Date: Thu, 14 Sep 2006 11:55:52 +0400 From: Ruslan Ermilov <ru@freebsd.org> To: "David O'Brien" <obrien@freebsd.org> Cc: Juli Mallett <jmallett@freebsd.org>, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/share/mk bsd.lib.mk bsd.prog.mk Message-ID: <20060914075552.GB8784@rambler-co.ru> In-Reply-To: <20060913235810.GA87164@dragon.NUXI.org> References: <200609132327.k8DNRMqS076204@repoman.freebsd.org> <20060913233211.GA83839@toxic.magnesium.net> <20060913235810.GA87164@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Sep 13, 2006 at 04:58:10PM -0700, David O'Brien wrote: > On Wed, Sep 13, 2006 at 01:32:11PM -1000, Juli Mallett wrote: > > [ cvs commit: src/share/mk bsd.lib.mk bsd.prog.mk ] > > > When building WITHOUT_ASSERT_DEBUG, we need to disable -Werror as its easy > > > to see "warning: unused variable `foo'". > > > > I think it might be a better idea to -Wno-unused, since the only sorts of > > warnings one wants to ignore building NDEBUG are the variables which are > > otherwise unused. > > Hum.. I assumed that WITHOUT_ASSERT_DEBUG was a rare case and used as > part of producing a production release where one knows /usr/src builds > as-usual. -Wno-unused would scratch this itch, but we need to find a way > to codify it so that we're not putting GCC options into share/mk. I > guess make a NO_WUNUSED knob. > I think what you have committed is appropriate. Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFCQsIqRfpzJluFF4RAo9qAJ9cbgiqqjdi6GbP18qVqAhFzVb3MACeLtmL Ywl4WjikpCstPPsJONjq/uE= =dPat -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060914075552.GB8784>