Date: Mon, 11 Aug 2008 18:07:03 -0700 From: Sean Bruno <sbruno@miralink.com> To: Dieter <freebsd@sopwith.solgatos.com> Cc: Scott Long <scottl@freebsd.org>, freebsd-firewire@freebsd.org Subject: Re: This is where I'm going with fwcontrol Message-ID: <48A0E237.5020702@miralink.com> In-Reply-To: <200808120033.AAA07139@sopwith.solgatos.com> References: <200808120033.AAA07139@sopwith.solgatos.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Dieter wrote: >> Also, I changed some of the variable to check for >= 0 and set their >> default values to -1. This should have the same effect as adding a new >> variable as you did in your fix. >> > > If you're going to do it that way, the code should check that the argument > is in range, and print a complaint if out of range. Otherwise the user could > say "fwcontrol -f -1" and nothing would happen. And the man page should list > the legal range. Hmmm, actually these should be done even with the > add-a-new-variable method. > Excellent feedback, let me work on something tonight and reissue the patch. -- Sean Bruno MiraLink Corporation 6015 NE 80th Ave, Ste 100 Portland, OR 97218 Cell 503-358-6832 Phone 503-621-5143 Fax 503-621-5199 MSN: sbruno@miralink.com Google: seanwbruno@gmail.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48A0E237.5020702>