Date: Thu, 26 Mar 2026 08:53:37 -0600 From: Alan Somers <asomers@freebsd.org> To: Gleb Popov <arrowd@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 62aef3f73f38 - main - vfs_cluster.c: Do not propagate VOP_BMAP errors to the caller Message-ID: <CAOtMX2irzNfaE8RwTibf9_Pp2nuFv%2B5SMm5LOVVCJvo0-cfOtw@mail.gmail.com> In-Reply-To: <202510221659.59MGxpsK054765@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Wed, Oct 22, 2025 at 11:00 AM Gleb Popov <arrowd@freebsd.org> wrote: > > The branch main has been updated by arrowd: > > URL: https://cgit.FreeBSD.org/src/commit/?id=62aef3f73f38db9fb68bffc12cc8900fecd58f0e > > commit 62aef3f73f38db9fb68bffc12cc8900fecd58f0e > Author: Gleb Popov <arrowd@FreeBSD.org> > AuthorDate: 2025-07-11 07:42:09 +0000 > Commit: Gleb Popov <arrowd@FreeBSD.org> > CommitDate: 2025-10-22 16:59:21 +0000 > > vfs_cluster.c: Do not propagate VOP_BMAP errors to the caller > > The code that makes this VOP_BMAP call tries to perform a read-ahead I/O > operation. Failing to do that for any reason isn't fatal for `cluster_read()`, > because we still can return some data to the caller. This change is consistent > with other places within `cluster_read()`, where error returned by VOP_BMAP is > not returned to the caller - see the `if (nblks > 1)` block above the changed > lines and `if (reqbp)` at the end of the function. > > PR: 264196 > Approved by: markj, kib > Differential Revision: https://reviews.freebsd.org/D51254 Shall we MFC this change? I think it affects 15.0-RELEASE.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2irzNfaE8RwTibf9_Pp2nuFv%2B5SMm5LOVVCJvo0-cfOtw>