Date: Thu, 8 Dec 2022 17:00:03 -0800 From: Eric Joyner <erj@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: cdcd52d41e24 - main - irdma: Add RDMA driver for Intel(R) Ethernet Controller E810 Message-ID: <CAKdFRZj%2BNUVF%2Bc5bcUqyX-wffO9XUK=e%2BjwFAdZrYFtHWq3OWw@mail.gmail.com> In-Reply-To: <d53a9af3-219b-9849-c537-9df0f2ba2ba2@FreeBSD.org> References: <202205232354.24NNs69N032987@gitrepo.freebsd.org> <c0b2824f-6386-b8ba-90f3-f347155ba87b@FreeBSD.org> <CAKdFRZibhP3Ap_S_Gj=CY3uhVdLxkS2C%2BaeqfZf18wyn==TUiA@mail.gmail.com> <d53a9af3-219b-9849-c537-9df0f2ba2ba2@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000001cc81205ef5aadc9 Content-Type: text/plain; charset="UTF-8" Yeah, I was able to repro it and get what I think is the error in a nicer-to-read set of lines: Building /root/build/head/obj/root/build/head/src/amd64.amd64/lib/ofed/libirdma/libirdma.a building static irdma library Building /root/build/head/obj/root/build/head/src/amd64.amd64/lib/ofed/libirdma/libirdma.so.1.full building shared library libirdma.so.1 /usr/local/bin/x86_64-unknown-freebsd14.0-ld: duplicate expression `*' in version information collect2: error: ld returned 1 exit status *** [libirdma.so.1.full] Error code 1 What does that even mean? I don't know anything about building libraries. - Eric On Wed, Dec 7, 2022 at 1:05 PM John Baldwin <jhb@freebsd.org> wrote: > On 6/13/22 2:18 PM, Eric Joyner wrote: > > On Fri, Jun 10, 2022 at 3:29 PM John Baldwin <jhb@freebsd.org> wrote: > > > >> On 5/23/22 4:54 PM, Eric Joyner wrote: > >>> The branch main has been updated by erj: > >>> > >>> URL: > >> > https://cgit.FreeBSD.org/src/commit/?id=cdcd52d41e246ba1c0fcfad0769bd691487355ef > >>> > >>> commit cdcd52d41e246ba1c0fcfad0769bd691487355ef > >>> Author: Bartosz Sobczak <bartosz.sobczak@intel.com> > >>> AuthorDate: 2022-05-23 23:39:27 +0000 > >>> Commit: Eric Joyner <erj@FreeBSD.org> > >>> CommitDate: 2022-05-23 23:52:49 +0000 > >>> > >>> irdma: Add RDMA driver for Intel(R) Ethernet Controller E810 > >>> > >>> This is an initial commit for RDMA FreeBSD driver for Intel(R) > >> Ethernet > >>> Controller E810, called irdma. Supporting both RoCEv2 and iWARP > >>> protocols in per-PF manner, RoCEv2 being the default. > >>> > >>> Testing has been done using krping tool, perftest, ucmatose, > rping, > >>> ud_pingpong, rc_pingpong and others. > >>> > >>> Signed-off-by: Eric Joyner <erj@FreeBSD.org> > >>> > >>> Reviewed by: #manpages (pauamma_gundo.com) [documentation] > >>> MFC after: 1 week > >>> Relnotes: yes > >>> Sponsored by: Intel Corporation > >>> Differential Revision: https://reviews.freebsd.org/D34690 > >> > >> I'm trying to get the tree building again with GCC and ld.bfd does not > like > >> libirdma.map at all complaining with an error: > >> > >> duplicate expression '*' in version information > >> > >> I looked at the version map, and it seems rather bogus to me and not > like > >> version maps used anywhere else. It seems to be exporting all symbols > in > >> two different versions? That would seem to defeat the point of having > >> symbol versions? > >> > >> /* Export symbols should be added below according to > >> Documentation/versioning.md document. */ > >> IRDMA_1.0 { > >> global: *; > >> local: *; > >> }; > >> > >> IRDMA_1.1 { > >> global: *; > >> } IRDMA_1.0; > >> > >> (I'm also not sure why lld accepts such a version map.) > >> > >> -- > >> John Baldwin > >> > > > > Hi, > > > > I don't know how to answer this; I'm going to forward this to the FreeBSD > > RDMA guy and another one (the first guy might still be out on vacation) > and > > see if they can answer this. > > FYI, this is now the current breakage for the new GCC 12 job in FreeBSD's > CI: > > https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc12_build/47/console > > The error is buried in the log there, but should be obtainable by doing > 'pkg install amd64-gcc12' and 'make CROSS_TOOLCHAIN=amd64-gcc12 buildworld' > on main. > > -- > John Baldwin > > --0000000000001cc81205ef5aadc9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Yeah, I was able to repro it and get what I think is the e= rror in a nicer-to-read set of lines:<div><br></div><div>Building /root/bui= ld/head/obj/root/build/head/src/amd64.amd64/lib/ofed/libirdma/libirdma.a = =C2=A0 =C2=A0 =C2=A0 =C2=A0<br>building static irdma library =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 <br>Building /root/build/head/obj/root/build/head/src/amd64.amd64/lib/o= fed/libirdma/libirdma.so.1.full<br>building shared library libirdma.so.1 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <br>/usr/loc= al/bin/x86_64-unknown-freebsd14.0-ld: duplicate expression `*' in versi= on information =C2=A0 =C2=A0 <br>collect2: error: ld returned 1 exit status= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<br>*** [libirdma.so.1.full= ] Error code 1=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0<br></div><div><br></div><div>What does that even mean? I don'= ;t know anything about building libraries.</div><div><br></div><div>- Eric<= /div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_a= ttr">On Wed, Dec 7, 2022 at 1:05 PM John Baldwin <<a href=3D"mailto:jhb@= freebsd.org">jhb@freebsd.org</a>> wrote:<br></div><blockquote class=3D"g= mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204= ,204,204);padding-left:1ex">On 6/13/22 2:18 PM, Eric Joyner wrote:<br> > On Fri, Jun 10, 2022 at 3:29 PM John Baldwin <<a href=3D"mailto:jhb= @freebsd.org" target=3D"_blank">jhb@freebsd.org</a>> wrote:<br> > <br> >> On 5/23/22 4:54 PM, Eric Joyner wrote:<br> >>> The branch main has been updated by erj:<br> >>><br> >>> URL:<br> >> <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3Dcdcd52d41e246= ba1c0fcfad0769bd691487355ef" rel=3D"noreferrer" target=3D"_blank">https://c= git.FreeBSD.org/src/commit/?id=3Dcdcd52d41e246ba1c0fcfad0769bd691487355ef</= a><br> >>><br> >>> commit cdcd52d41e246ba1c0fcfad0769bd691487355ef<br> >>> Author:=C2=A0 =C2=A0 =C2=A0Bartosz Sobczak <<a href=3D"mail= to:bartosz.sobczak@intel.com" target=3D"_blank">bartosz.sobczak@intel.com</= a>><br> >>> AuthorDate: 2022-05-23 23:39:27 +0000<br> >>> Commit:=C2=A0 =C2=A0 =C2=A0Eric Joyner <erj@FreeBSD.org>= <br> >>> CommitDate: 2022-05-23 23:52:49 +0000<br> >>><br> >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0irdma: Add RDMA driver for Intel(R) = Ethernet Controller E810<br> >>><br> >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0This is an initial commit for RDMA F= reeBSD driver for Intel(R)<br> >> Ethernet<br> >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Controller E810, called irdma.=C2=A0= Supporting both RoCEv2 and iWARP<br> >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0protocols in per-PF manner, RoCEv2 b= eing the default.<br> >>><br> >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Testing has been done using krping t= ool, perftest, ucmatose, rping,<br> >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0ud_pingpong, rc_pingpong and others.= <br> >>><br> >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Signed-off-by: Eric Joyner <erj@F= reeBSD.org><br> >>><br> >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Reviewed by:=C2=A0 =C2=A0 #manpages = (<a href=3D"http://pauamma_gundo.com" rel=3D"noreferrer" target=3D"_blank">= pauamma_gundo.com</a>) [documentation]<br> >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0MFC after:=C2=A0 =C2=A0 =C2=A0 1 wee= k<br> >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Relnotes:=C2=A0 =C2=A0 =C2=A0 =C2=A0= yes<br> >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Sponsored by:=C2=A0 =C2=A0Intel Corp= oration<br> >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Differential Revision:=C2=A0 <a href= =3D"https://reviews.freebsd.org/D34690" rel=3D"noreferrer" target=3D"_blank= ">https://reviews.freebsd.org/D34690</a><br>; >><br> >> I'm trying to get the tree building again with GCC and ld.bfd = does not like<br> >> libirdma.map at all complaining with an error:<br> >><br> >> duplicate expression '*' in version information<br> >><br> >> I looked at the version map, and it seems rather bogus to me and n= ot like<br> >> version maps used anywhere else.=C2=A0 It seems to be exporting al= l symbols in<br> >> two different versions?=C2=A0 That would seem to defeat the point = of having<br> >> symbol versions?<br> >><br> >> /* Export symbols should be added below according to<br> >>=C2=A0 =C2=A0 =C2=A0 Documentation/versioning.md document. */<br> >> IRDMA_1.0 {<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 global: *;<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 local: *;<br> >> };<br> >><br> >> IRDMA_1.1 {<br> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 global: *;<br> >> } IRDMA_1.0;<br> >><br> >> (I'm also not sure why lld accepts such a version map.)<br> >><br> >> --<br> >> John Baldwin<br> >><br> > <br> > Hi,<br> > <br> > I don't know how to answer this; I'm going to forward this to = the FreeBSD<br> > RDMA guy and another one (the first guy might still be out on vacation= ) and<br> > see if they can answer this.<br> <br> FYI, this is now the current breakage for the new GCC 12 job in FreeBSD'= ;s CI:<br> <br> <a href=3D"https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc12_build/47/con= sole" rel=3D"noreferrer" target=3D"_blank">https://ci.freebsd.org/job/FreeB= SD-main-amd64-gcc12_build/47/console</a><br> <br> The error is buried in the log there, but should be obtainable by doing<br> 'pkg install amd64-gcc12' and 'make CROSS_TOOLCHAIN=3Damd64-gcc= 12 buildworld'<br> on main.<br> <br> -- <br> John Baldwin<br> <br> </blockquote></div> --0000000000001cc81205ef5aadc9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKdFRZj%2BNUVF%2Bc5bcUqyX-wffO9XUK=e%2BjwFAdZrYFtHWq3OWw>