Date: Sun, 6 May 2001 03:10:02 -0700 (PDT) From: Bruce Evans <bde@zeta.org.au> To: freebsd-bugs@FreeBSD.org Subject: Re: conf/27089: Missing include in /usr/include/sys/conf.h Message-ID: <200105061010.f46AA2W96013@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR conf/27089; it has been noted by GNATS. From: Bruce Evans <bde@zeta.org.au> To: Kris Kennaway <kris@obsecurity.org> Cc: freebsd-gnats-submit@FreeBSD.ORG Subject: Re: conf/27089: Missing include in /usr/include/sys/conf.h Date: Sun, 6 May 2001 20:01:03 +1000 (EST) On Sat, 5 May 2001, Kris Kennaway wrote: > On Sat, May 05, 2001 at 07:09:17AM +0000, Udo Schweigert wrote: > > > /usr/include/sys/conf.h references struct timespec which is defined in > > /usr/include/sys/time.h. Since /usr/include/sys/time.h is not included by > > /usr/include/sys/conf.h this results in an error (for example when trying > > to build the sysutils/xosview port). > > > #include <sys/eventhandler.h> > > +#include <sys/time.h> > > This is probably the wrong thing to do..the correct thing is to fix > the broken software which makes that assumption. It's not clear if the broken software is <sys/conf.h> or xosview. A few applications in /usr/src include <sys/conf.h>. At least fstat/fstat.c sort of needs to, since it wants convert kernel dev_t's to userland dev_t's. Kernel dev_t's are now pointers, and <sys/conf.h> is the only place that declares the struct that they point to. OTOH, top/machine.c includes <sys/conf.h> for no reason. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200105061010.f46AA2W96013>