Date: Sat, 21 Dec 2013 08:49:56 -0600 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: Devin Teske <dteske@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r259468 - head/usr.sbin/bsdinstall/scripts Message-ID: <52B5AA94.3060009@freebsd.org> In-Reply-To: <52AF2502.1060503@freebsd.org> References: <201312161550.rBGFox0N001344@svn.freebsd.org> <52AF2502.1060503@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Could you please revert this and move the fix to the correct place? -Nathan On 12/16/13 10:06, Nathan Whitehorn wrote: > Please add this to release/rc.local instead under the console setup. > There is no guarantee that "auto" is running from an environment where > this is defined -- for example, it may be running from a serial > console or an xterm -- and the actual installer should not be polluted > with assumptions about the media from which it runs. > -Nathan > > On 12/16/13 09:50, Devin Teske wrote: >> Author: dteske >> Date: Mon Dec 16 15:50:59 2013 >> New Revision: 259468 >> URL: http://svnweb.freebsd.org/changeset/base/259468 >> >> Log: >> Add a fix for Long-standing problem with VMware. Described in >> below links: >> https://communities.vmware.com/thread/107230 >> https://communities.vmware.com/docs/DOC-11677 >> Basically, ignore the ``function 62'' and ``function 63'' >> interpretations >> of the left/right command key when we're in the lengthiest portion >> of the >> installation (initiated by the `auto' module). >> The net effect is that you can now (once you've started the >> installer from >> the media) escape the VM without prematurely terminating the >> current action >> due to spurious escape sequence. >> MFC after: 3 days >> >> Modified: >> head/usr.sbin/bsdinstall/scripts/auto >> >> Modified: head/usr.sbin/bsdinstall/scripts/auto >> ============================================================================== >> >> --- head/usr.sbin/bsdinstall/scripts/auto Mon Dec 16 15:08:30 >> 2013 (r259467) >> +++ head/usr.sbin/bsdinstall/scripts/auto Mon Dec 16 15:50:59 >> 2013 (r259468) >> @@ -49,6 +49,10 @@ error() { >> ############################################################ MAIN >> +# Don't send ESC on function-key 62/63 (left/right command key) >> +f_quietly kbdcontrol -f 62 '' >> +f_quietly kbdcontrol -f 63 '' >> + >> f_dprintf "Began Installation at %s" "$( date )" >> rm -rf $BSDINSTALL_TMPETC >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52B5AA94.3060009>