Date: 24 Nov 2004 18:23:04 -0000 From: "freebsd@simplerezo.com" <freebsd@simplerezo.com> To: FreeBSD-gnats-submit@FreeBSD.org Cc: doc@FreeBSD.org Subject: docs/74328: [books/porters-handbook] Adding a call sample for pkg-install in Makefile Message-ID: <20041124182304.70684.qmail@xeon.ouestil.com> Resent-Message-ID: <200411241830.iAOIUOFT028435@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 74328 >Category: docs >Synopsis: [books/porters-handbook] Adding a call sample for pkg-install in Makefile >Confidential: no >Severity: non-critical >Priority: high >Responsible: freebsd-doc >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Wed Nov 24 18:30:24 GMT 2004 >Closed-Date: >Last-Modified: >Originator: freebsd@simplerezo.com >Release: FreeBSD 4.9-RELEASE-p12 i386 >Organization: SimpleRezo [http://www.simplerezo.com] >Environment: System: FreeBSD ---.simplerezo.com 4.9-RELEASE-p12 FreeBSD 4.9-RELEASE-p12 #0: Sun Nov 7 15:23:05 CET 2004 root@:/usr/obj/usr/src/sys/KERNEL i386 >Description: Because a lot of maintainer does not make a correct call to the pkg-install script in their Makefile, i think we should include a sample. Adding @PKG_PREFIX=${PREFIX} ${SH} pkg-install ${PKGNAME} PRE-INSTALL is a mistake because with a WRKDIRPREFIX variable set, this would not work: pkg-install have to be replaced with the PKG-INSTALL variable substitution instead. >How-To-Repeat: >Fix: --- book.sgml.diff begins here --- --- book.sgml.orig Wed Nov 24 19:08:15 2004 +++ book.sgml Wed Nov 24 19:13:15 2004 @@ -5014,7 +5014,9 @@ <para>This script is not run automatically if you install the port with <command>make install</command>. If you are depending on it being run, you will have to explicitly call it from your port's - <filename>Makefile</filename>.</para> + <filename>Makefile</filename>, with a line like + <literal>@PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} + ${PKGNAME} PRE-INSTALL</literal>.</para> </note> </sect1> --- book.sgml.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041124182304.70684.qmail>