Date: Mon, 20 Jan 2003 16:04:36 +0300 (MSK) From: Maxim Konovalov <maxim@FreeBSD.org> To: Wiktor Niesiobedzki <w@evip.pl> Cc: current@FreeBSD.org Subject: Re: Dummynet messages Message-ID: <20030120160354.P91305@news1.macomnet.ru> In-Reply-To: <20030119224311.GB89748@mail.evip.pl> References: <20030119224311.GB89748@mail.evip.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23:43+0100, Jan 19, 2003, Wiktor Niesiobedzki wrote:
> Hi,
>
> sys/netinet/ip_dummynet.c:
> 975: if (q->avg >= fs->max_th) { /* average queue >= max threshold */
> (...)
> 984: } else {
> 985: q->count = -1;
> 986: printf("- drop");
> 987: return 1 ;
> 989: }
>
> is quite meaningless. Shouldn't be it at least DEB(printf("- drop")? Or
> better "drop - max_th exceeded"?
>
> Just a small proposition, I was quite confused, when I saw this message.
Fixed in rev. 1.61 sys/netinet/ip_dummynet.c, thanks.
--
Maxim Konovalov, maxim@macomnet.ru, maxim@FreeBSD.org, +7 (095) 796979
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030120160354.P91305>