Date: Wed, 22 May 2019 19:49:25 +0000 (UTC) From: Alan Somers <asomers@FreeBSD.org> To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r348119 - projects/fuse2/sys/fs/fuse Message-ID: <201905221949.x4MJnPpV045128@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: asomers Date: Wed May 22 19:49:25 2019 New Revision: 348119 URL: https://svnweb.freebsd.org/changeset/base/348119 Log: fusefs: remove the vfs.fusefs.sync_resize syctl, correctly this time In r347547 I intended to remove the vfs.fusefs.sync_resize sysctl, leaving fusefs's behavior as though sync_resize had its default value. But I forgot that I had already turned off sync_resize in my development system's /etc/sysctl.conf. This commit complete removes the optional behavior that was formerly controlled by sync_resize. There's no need for explicitly calling FUSE_SETATTR after every FUSE_WRITE that extends a file. The daemon can infer that the file is being extended. If this sysctl was added as a workaround for a buggy daemon, there's no clue as to what that daemon may have been. Sponsored by: The FreeBSD Foundation Modified: projects/fuse2/sys/fs/fuse/fuse_io.c Modified: projects/fuse2/sys/fs/fuse/fuse_io.c ============================================================================== --- projects/fuse2/sys/fs/fuse/fuse_io.c Wed May 22 19:39:55 2019 (r348118) +++ projects/fuse2/sys/fs/fuse/fuse_io.c Wed May 22 19:49:25 2019 (r348119) @@ -528,7 +528,6 @@ static int fuse_write_biobackend(struct vnode *vp, struct uio *uio, struct ucred *cred, struct fuse_filehandle *fufh, int ioflag, pid_t pid) { - struct fuse_vnode_data *fvdat = VTOFUD(vp); struct buf *bp; daddr_t lbn; off_t filesize; @@ -749,9 +748,6 @@ again: if (err) break; } while (uio->uio_resid > 0 && n > 0); - - if ((fvdat->flag & FN_SIZECHANGE) != 0) - fuse_vnode_savesize(vp, cred, pid); return (err); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201905221949.x4MJnPpV045128>