Date: Fri, 13 Aug 2010 11:12:52 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Takanori Watanabe <takawata@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r211252 - head/usr.sbin/acpi/acpidump Message-ID: <86y6caswob.fsf@ds4.des.no> In-Reply-To: <201008130045.o7D0jUW6043601@svn.freebsd.org> (Takanori Watanabe's message of "Fri, 13 Aug 2010 00:45:30 %2B0000 (UTC)") References: <201008130045.o7D0jUW6043601@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Takanori Watanabe <takawata@FreeBSD.org> writes:
> @@ -647,7 +646,7 @@ acpi_handle_tcpa(ACPI_TABLE_HEADER *sdp)
> printf(END_COMMENT);
> return;
> }
> - printf("\tClass %d Base Address 0x%jx Length %" PRIu64 "\n\n",
> + printf("\tClass %u Base Address 0x%jx Length %ju\n\n",
> tcpa->platform_class, paddr, len);
>=20=20
> if (len =3D=3D 0) {
This is still wrong, just a different kind of wrong. Just because the
compiler doesn't complain doesn't mean it's right. Did you even read
what John and I wrote?
DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86y6caswob.fsf>