Date: Sat, 7 Nov 2015 17:56:36 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Andrey Chernov <ache@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, jasone@FreeBSD.org Subject: Re: svn commit: r290499 - head/usr.bin/localedef Message-ID: <20151107165636.GA31396@ivaldir.etoilebsd.net> In-Reply-To: <563E2BA6.9020505@freebsd.org> References: <201511071622.tA7GMTDN099727@repo.freebsd.org> <563E2BA6.9020505@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 07, 2015 at 07:49:42PM +0300, Andrey Chernov wrote: > On 07.11.2015 19:22, Baptiste Daroussin wrote: > > Author: bapt > > Date: Sat Nov 7 16:22:29 2015 > > New Revision: 290499 > > URL: https://svnweb.freebsd.org/changeset/base/290499 > >=20 > > Log: > > Workaround an issue on i386 to unbreak the build until the real issue= is tracked > > down > > - large =3D calloc(sizeof (collate_large_t) * n, 1); > > + large =3D malloc(sizeof (collate_large_t) * n); > > + memset(large, 0, sizeof (collate_large_t) * n); >=20 > Should be calloc(n, sizeof (collate_large_t)) according to calloc usage > and to prevent size_t overflow. Is it calloc() bug? I have tried all combinaison with calloc before committing the workaround, = all fails the same way on i386: <jemalloc>: jemalloc_arena.c:353: Failed assertion: "p[i] =3D=3D 0" So yes I'm thinking about a calloc bug (Jason CCed) FYI sizeof(collate_large_t) is 44 there and n is 1145 Best regards, Bapt --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlY+LUQACgkQ8kTtMUmk6Ewl9QCgnfCjkV77VCdYqHVOfXL042pP ElQAn0qAVxekWG103NuWoLmvsR8HNuD8 =I67P -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151107165636.GA31396>