Date: Mon, 25 Apr 2011 22:07:36 -0600 From: Warner Losh <imp@bsdimp.com> To: Ryan Stone <rysto32@gmail.com> Cc: arch@FreeBSD.org, George Neville-Neil <gnn@neville-neil.com> Subject: Re: Is there any reason not to remove all the spl() calls in rtsock.c? Message-ID: <D89CFB81-32E3-4606-BB34-52F54D57149A@bsdimp.com> In-Reply-To: <BANLkTi=gpjLB_nb2StJPbqKXtEhu9Zu9YA@mail.gmail.com> References: <7DC6C171-3802-4B5D-B2D8-2191C6FF6DBA@neville-neil.com> <BANLkTi=gpjLB_nb2StJPbqKXtEhu9Zu9YA@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On Apr 25, 2011, at 8:09 PM, Ryan Stone wrote: > On Mon, Apr 25, 2011 at 9:59 PM, George Neville-Neil > <gnn@neville-neil.com> wrote: >> Howdy, >> >> I was just reviewing the code in rtsock.c, specifically rts_attach(). Is there any reason >> not to just remove the spl* calls? I don't see anything obvious that needs protection >> that is not now protected by a finer grained lock. Likely they can go. Only reason to keep them at all at this point is if there's still stuff that isn't locked, which should be only a tiny fraction of the tree... Warner >> >> Best, >> George > > The spl* calls have been no-ops for over 10 years now(since r71240), > so I certainly hope that there's nothing requiring their protection. > > It's probably long-past time to kill off those stubs, I'd imagine. > _______________________________________________ > freebsd-arch@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" > >home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D89CFB81-32E3-4606-BB34-52F54D57149A>