Date: Fri, 13 Apr 2007 05:12:16 GMT From: Scott Long <scottl@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 117988 for review Message-ID: <200704130512.l3D5CGQA034970@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=117988 Change 117988 by scottl@scottl-y1 on 2007/04/13 05:11:35 Drop the periph lock around calling make_dev Affected files ... .. //depot/projects/scottl-camlock/src/sys/cam/scsi/scsi_ch.c#10 edit .. //depot/projects/scottl-camlock/src/sys/cam/scsi/scsi_ses.c#12 edit .. //depot/projects/scottl-camlock/src/sys/cam/scsi/scsi_sg.c#5 edit Differences ... ==== //depot/projects/scottl-camlock/src/sys/cam/scsi/scsi_ch.c#10 (text+ko) ==== @@ -374,9 +374,11 @@ DEVSTAT_PRIORITY_OTHER); /* Register the device */ + cam_periph_unlock(periph); softc->dev = make_dev(&ch_cdevsw, periph->unit_number, UID_ROOT, GID_OPERATOR, 0600, "%s%d", periph->periph_name, periph->unit_number); + cam_periph_lock(periph); softc->dev->si_drv1 = periph; /* ==== //depot/projects/scottl-camlock/src/sys/cam/scsi/scsi_ses.c#12 (text+ko) ==== @@ -364,9 +364,11 @@ return (CAM_REQ_CMP_ERR); } + cam_periph_unlock(periph); softc->ses_dev = make_dev(&ses_cdevsw, unit2minor(periph->unit_number), UID_ROOT, GID_OPERATOR, 0600, "%s%d", periph->periph_name, periph->unit_number); + cam_periph_lock(periph); softc->ses_dev->si_drv1 = periph; /* ==== //depot/projects/scottl-camlock/src/sys/cam/scsi/scsi_sg.c#5 (text+ko) ==== @@ -319,11 +319,13 @@ DEVSTAT_PRIORITY_PASS); /* Register the device */ + cam_periph_unlock(periph); softc->dev = make_dev(&sg_cdevsw, unit2minor(periph->unit_number), UID_ROOT, GID_OPERATOR, 0600, "%s%d", periph->periph_name, periph->unit_number); softc->devalias = make_dev_alias(softc->dev, "sg%c", 'a' + periph->unit_number); + cam_periph_lock(periph); softc->dev->si_drv1 = periph; /*
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200704130512.l3D5CGQA034970>