Date: Sat, 30 Jan 2016 21:56:21 -0700 From: Warner Losh <imp@bsdimp.com> To: mokhi <mokhi64@gmail.com> Cc: Ian Lepore <ian@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: thread-unsafety problems as spl*() ones are NOP Message-ID: <37EC2460-9C4D-46D4-91A1-FA6CE7B0BFB1@bsdimp.com> In-Reply-To: <CAByVWPXu==acGjv54XCfawY7gmbB0SxrGrVff0f94QMqu6tf5A@mail.gmail.com> References: <CAByVWPWuqdtZ-5p2%2BvGf4v%2BPjjCBkiTQSsZQ06vk-f=bx_TQrQ@mail.gmail.com> <CAByVWPWQJ1wP95S59SiWWBa0k9j2%2Bu1az-D04_V1voo99CxqCw@mail.gmail.com> <1454188175.32550.3.camel@freebsd.org> <CANCZdfrUjy=C0yjcW3QYbCHzYzAmrmC16GY2kpjKDoCBiCj_7Q@mail.gmail.com> <CAByVWPXu==acGjv54XCfawY7gmbB0SxrGrVff0f94QMqu6tf5A@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Jan 30, 2016, at 9:37 PM, mokhi <mokhi64@gmail.com> wrote: > > @imp So you think I should start to put locks there and see what happens? :) I’d advocate a deeper understanding of the code. splXXX() is for code path exclusion. Locks are for data protection. These are subtly different concepts and may cause issues when you try to just blindly replace the splXXX with a lock. You can start there, but you’ll still need to do code-path analysis to see what the locks wind up protecting, and then see if there’s any access to it outside of locked paths. Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJWrZP2AAoJEGwc0Sh9sBEAw44P/iBx3u74ep2s/GweTA62DAHS Kg1LJSqMYhkNVBM8Qss18pc0XpPDbWEoQFYsUvh+jN0isB20gomU3CFvkxk1un1Q twJVUIT55rdaqR4kt5Ds/+/oQyQH3B83u8LRvNCn+kHKLeopjttUJidk/gF2gIs1 anohnlTEpSsgU2chRjGPGa7g9+/tuBm44SDjIbuMHjmF5IOHldIkU03jY1e0Yhni wcG28dRhXsJas5OAmK/dJBESHhjnvo/ueciKRcCmiPm2di2LtevLcX0TJ49mFU1u y4US85LmSrLWvbIRBbVI1MNMUZG+zwqd0MrQPYjeBeSgW/FfYZiV49tTIpXRSLhr gFV9eXxRayc/k6asN3G6X06kl1YZlAOgCsul3EdFJU0N3Bw/CrdRVLEynWVRXLbp TXBGV4bHJShgbDBc2zYYVWjLvuTLu5I1cPPXCApy+X3KJm8wpkmWBhhbNZIzjh0y 2aVXeHzovLMZHcrb5UncaFA+jRaZ/m5Z/mqgYZW1WysRm2MsxufksJbFQmLnDyk8 R3T3Qr/5TTndXEiynDG0SOul//K5lYvLIMjvqw9z5xOj++n3UcRUN6zXUFHURpJd w+wPgbKvThn579cY0MxGIjiiC4heM/SHs0+iKNS4/hi/AGq8pAefiUnGTHN4G9wo SGv0MdIBlPlWLtvELq8O =+sh4 -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?37EC2460-9C4D-46D4-91A1-FA6CE7B0BFB1>