Date: Tue, 24 Apr 2001 20:34:27 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Mark Murray <mark@grondar.za> Cc: smp@FreeBSD.ORG Subject: Re: Kernel include file cleanup take #3. Message-ID: <Pine.BSF.4.21.0104242030390.15368-100000@besplex.bde.org> In-Reply-To: <200104230602.f3N62Tw49163@gratis.grondar.za>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 23 Apr 2001, Mark Murray wrote: > > > http://people.freebsd.org/~markm/patches/sys.SYS_MUTEX.diff.1 > > You actually made <sys/lockmgr.h> a subinclude of > > other headers that need it, and one that doesn't (<sys/conf.h> doesn't > > need it directly, but it includes <sys/eventhandler.h> which does). > > OK. Removed it (plus some other junk) from eventhandler. From conf? > > Please change the copyright owner to yourself. FreeBSD, Inc. still > > doesn't exist in a form suitable for holding copyrights. > > OK. Done. For such small files I'd prefer them to be owned by the project, > but I don't care enough to be religious about it. Actually, the copyrights from the original files would be better. > > I'm not sure if the names for the new types headers are right. Perhaps > > they should have a leading underscore to inhibit direct inclusion, or > > not have the "_types" suffix, to make them less verbose and not hint > > that they are limited to types. > > How about _mutex.h and _lock.h? OK. The pfind() changes gave about another .c files that need <sys/mutex.h> but don't include it. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0104242030390.15368-100000>