Date: Sat, 14 Feb 2009 15:17:27 -0800 From: Sam Leffler <sam@freebsd.org> To: Alexander Motin <mav@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r188621 - head/sys/dev/ata/chipsets Message-ID: <49975107.1070803@freebsd.org> In-Reply-To: <200902142302.n1EN2xp0032837@svn.freebsd.org>
index | next in thread | previous in thread | raw e-mail
Alexander Motin wrote: > Author: mav > Date: Sat Feb 14 23:02:59 2009 > New Revision: 188621 > URL: http://svn.freebsd.org/changeset/base/188621 > > Log: > Tunes to AHCI reset sequences: > - specification claims that 1 second is just a maximum controller reset time; > implement controller reset properly to save almost 1 second of boot, and > about half second of resume time; > - enable channel interrupts only after channel status reset to fix duplicate > device creation on resume due to unwanted device connection event; > - as described in specification, wait for disk ready status after channel > power-up; it is not so important when disk already touched by BIOS, but > solves device not ready problems on resume and probably some other cases. > - uncomment channel stop/start on soft-reset as it is declared mandatory by > specification; it was commented due to some random drive detection problems > on VIA and JMicron controllers, but I hope it is fixed by previous point. > > These sounds like unrelated changes. Given the fragility of ata interop you should do these as separate commits in case folks need to bisect changes on breakage. Samhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49975107.1070803>