Date: Tue, 11 Aug 2015 16:01:55 +0200 From: Ed Schouten <ed@nuxi.nl> To: Koop Mast <kwm@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286524 - in head: . etc sys/dev/drm sys/dev/drm2 Message-ID: <CABh_MK=HiU-xNu1woz6koPxqtSjOb0rNXKxj=0gENkD44CkcAg@mail.gmail.com> In-Reply-To: <201508091258.t79CwvGj027161@repo.freebsd.org> References: <201508091258.t79CwvGj027161@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Koop, 2015-08-09 14:58 GMT+02:00 Koop Mast <kwm@freebsd.org>: > +#define DRM_DEV_GID 44 /* "video" group */ I think it looks a bit weird that DRM has these definitions locally. <sys/conf.h> already has definitions for various users and groups (UID_* and GID_*). Would it make sense to add GID_VIDEO to <sys/conf.h> and change the definitions in drmP.h to the following? #define DRM_DEV_UID UID_ROOT #define DRM_DEV_GID GID_VIDEO -- Ed Schouten <ed@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABh_MK=HiU-xNu1woz6koPxqtSjOb0rNXKxj=0gENkD44CkcAg>