Date: Sat, 24 Feb 2018 17:01:59 -0800 From: Conrad Meyer <cem@freebsd.org> To: Alan Somers <asomers@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329722 - head/cddl/usr.sbin/zdb Message-ID: <CAG6CVpWMDzfTNdtznb1yDBaXRMtwJdcR4DNFh3eJSATTDxM1-Q@mail.gmail.com> In-Reply-To: <CAOtMX2j%2BNhpUtWKLR9FeMbJ59WaTEKxNzASVr8BLkMdH44C7wQ@mail.gmail.com> References: <201802211551.w1LFpn57042314@repo.freebsd.org> <CAOtMX2jRP-him_s6_s6pdGgRzJFwHrPRLNo=1zMcvq5hqaqObg@mail.gmail.com> <CAG6CVpXLKUMmfN6rZLsDq7peFWb51GiayS_UMshBNF4kCF=53w@mail.gmail.com> <CAOtMX2j%2BNhpUtWKLR9FeMbJ59WaTEKxNzASVr8BLkMdH44C7wQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I did not see the array bounds error, but perhaps my build failed before it got to that point. Thanks for taking a look at it. Conrad On Sat, Feb 24, 2018 at 4:57 PM, Alan Somers <asomers@freebsd.org> wrote: > On Sat, Feb 24, 2018 at 5:19 PM, Conrad Meyer <cem@freebsd.org> wrote: >> >> On Wed, Feb 21, 2018 at 8:40 PM, Alan Somers <asomers@freebsd.org> wrote: >> > On Wed, Feb 21, 2018 at 8:51 AM, Alan Somers <asomers@freebsd.org> >> > wrote: >> >> >> >> Author: asomers >> >> Date: Wed Feb 21 15:51:48 2018 >> >> New Revision: 329722 >> >> URL: https://svnweb.freebsd.org/changeset/base/329722 >> >> >> >> Log: >> >> zdb: raise WARNS from 0 to 2 >> >> >> >> This has only been possible since r329694 and r329508 >> >> >> >> MFC after: 3 weeks >> >> X-MFC-With: 329694 >> >> X-MFC-With: 329508 >> >> Sponsored by: Spectra Logic >> >> >> >> Modified: >> >> head/cddl/usr.sbin/zdb/Makefile >> >> >> > >> > Looks like I broke the build with GCC-6. >> >> Yep, I can confirm it's broken. I don't see a flag we can just turn >> off for the GCC warning, though, so the solution might have to be >> CFLAGS.gcc += -Wno-error. >> >> > I'll fix it, as soon as I can get >> > the toolchain setup. >> >> The easy way is just: >> >> $ pkg install amd64-xtoolchain-gcc >> $ make -sj$(sysctl -n hw.ncpu) buildworld CROSS_TOOLCHAIN=amd64-gcc >> >> Thanks, >> Conrad > > > > There seem to be 3 problems: CTASSERT, assfail, and array bounds. I've > already committed a fix for CTASSERT and I'm testing an assfail fix now. > The array bounds problem is harder, though. The logic is complicated, but I > think it's sound. I don't know why GCC is complaining, unless maybe it > thinks that an enum type is signed. If I can't find a good solution, I'll > set -Wno-error as you suggest. > > -Alan >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpWMDzfTNdtznb1yDBaXRMtwJdcR4DNFh3eJSATTDxM1-Q>