Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Feb 2023 18:59:57 -0800
From:      Gleb Smirnoff <glebius@freebsd.org>
To:        Michael Tuexen <tuexen@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 453aa7fac989 - main - tcp: ensure the tcpcb is not NULL when logging an event
Message-ID:  <Y/bWrQbl6AC6xdYW@FreeBSD.org>
In-Reply-To: <202302230104.31N14Z9h029777@gitrepo.freebsd.org>
References:  <202302230104.31N14Z9h029777@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 23, 2023 at 01:04:35AM +0000, Michael Tuexen wrote:
M> The branch main has been updated by tuexen:
M> 
M> URL: https://cgit.FreeBSD.org/src/commit/?id=453aa7fac9894945282bcf6ef55c9ebaaa1d7e40
M> 
M> commit 453aa7fac9894945282bcf6ef55c9ebaaa1d7e40
M> Author:     Michael Tuexen <tuexen@FreeBSD.org>
M> AuthorDate: 2023-02-23 01:01:53 +0000
M> Commit:     Michael Tuexen <tuexen@FreeBSD.org>
M> CommitDate: 2023-02-23 01:04:17 +0000
M> 
M>     tcp: ensure the tcpcb is not NULL when logging an event
M>     
M>     When calling tcp_bblog_pru() on some error paths, tp is NULL,
M>     therefore handle it.

I wonder when does that happen? IMHO better fix such calls than
plug the problem here.

-- 
Gleb Smirnoff



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Y/bWrQbl6AC6xdYW>