Date: Fri, 10 Dec 2010 17:36:17 +0100 From: Tijl Coosemans <tijl@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216358 - head/sys/dev/le Message-ID: <201012101736.25488.tijl@freebsd.org> In-Reply-To: <201012101031.36641.jhb@freebsd.org> References: <201012101505.oBAF5n9X077454@svn.freebsd.org> <201012101031.36641.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Friday 10 December 2010 16:31:36 John Baldwin wrote: > On Friday, December 10, 2010 10:05:49 am Tijl Coosemans wrote: >> Author: tijl >> Date: Fri Dec 10 15:05:49 2010 >> New Revision: 216358 >> URL: http://svn.freebsd.org/changeset/base/216358 >> >> Log: >> Use SYS_RES_IOPORT instead of PCIM_CMD_PORTEN when calling pci_enable_io. >> >> Approved by: kib (mentor) > > To be honest, bus_alloc_resource() with RF_ACTIVE will set PORTEN or MEMEN for > you. Drivers should no longer be calling pci_enable_io() by hand. Looking into this, in dev/sound/pci/atiixp.c and dev/sound/pci/ich.c it is used during resume. Can those calls be removed as well? And in dev/mpt/mpt.c pci_enable_io and pci_disable_io are called in a number of places. Those should probably all stay? All other cases are during device attach with bus_alloc_resource+RF_ACTIVE before or after. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iF4EABEIAAYFAk0CVwkACgkQfoCS2CCgtit9rAD/bYOGsE+x2Zg1Vfz9c/AOriT1 ELRbquSk702wVQBC0xUA/jZmQWj4Zg9YrtJAqENQEAB0iQrD+P1kP6DT7NxCZwUy =Kk3z -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201012101736.25488.tijl>