Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 08 May 2018 20:05:15 +0100
From:      "N.J. Mann" <njm@njm.me.uk>
To:        Michael Tuexen <tuexen@FreeBSD.org>, svn-src-all@freebsd.org
Subject:   Re: svn commit: r333382 - head/sys/netinet
Message-ID:  <002E38ED710A92624EB727B0@triton.njm.me.uk>
In-Reply-To: <201805081848.w48Imq8b082041@repo.freebsd.org>
References:  <201805081848.w48Imq8b082041@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi,


On Tuesday, May 08, 2018 18:48:52 +0000 Michael Tuexen <tuexen@FreeBSD.org> wrote:
> Author: tuexen
> Date: Tue May  8 18:48:51 2018
> New Revision: 333382
> URL: https://svnweb.freebsd.org/changeset/base/333382
> 
> Log:
>   When reporting ERROR or ABORT chunks, don't use more data
>   that is guaranteed to be contigous.
                             ^^^^^^^^^
                             contiguous

[...]
> Modified: head/sys/netinet/sctputil.c
> ==============================================================================
> --- head/sys/netinet/sctputil.c	Tue May  8 18:25:37 2018	(r333381)
> +++ head/sys/netinet/sctputil.c	Tue May  8 18:48:51 2018	(r333382)
> @@ -2660,6 +2660,13 @@ sctp_notify_assoc_change(uint16_t state, struct sctp_t
>  		notif_len = (unsigned int)sizeof(struct sctp_assoc_change);
>  		if (abort != NULL) {
>  			abort_len = ntohs(abort->ch.chunk_length);
> +			/*
> +			 * Only SCTP_CHUNK_BUFFER_SIZE are guaranteed to be
> +			 * contiguos.
                           ^^^^^^^^^
                           contiguous

[...]
> @@ -3565,6 +3572,13 @@ sctp_notify_remote_error(struct sctp_tcb *stcb, uint16
>  	}
>  	if (chunk != NULL) {
>  		chunk_len = ntohs(chunk->ch.chunk_length);
> +		/*
> +		 * Only SCTP_CHUNK_BUFFER_SIZE are guaranteed to be
> +		 * contiguos.
                   ^^^^^^^^^
                   contiguous


Cheers,
       Nick.
-- 




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?002E38ED710A92624EB727B0>