Date: Mon, 27 Oct 2008 14:01:23 +0000 (UTC) From: Randall Stewart <rrs@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/netinet sctp_output.c Message-ID: <200810271401.m9RE1bQB012111@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rrs 2008-10-27 14:01:23 UTC
FreeBSD src repository
Modified files:
sys/netinet sctp_output.c
Log:
SVN rev 184336 on 2008-10-27 14:01:23Z by rrs
Two inter-related bugs.
- If we send EXACTLY the size left in the send buffer
and then send again, we end up with exactly 0 bytes and
don't hit the pre-block code to wait for more space.
- If we fall into the loop with our max_len == 0 (the bug
above) we then call in to copy out the data, setup the length
of the waiting to transmit data to 0 and call the mbuf copy routine
which 0 indicates copy all the data to the mbuf chain.. which it
does. This then leaves a "stuck" message on the stream queue with
its size exactly 0 bytes but all the data there and thus nothing
left in the uio structure. We then reach a stuck forever state
never being able to send data.
Revision Changes Path
1.78 +8 -2 src/sys/netinet/sctp_output.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810271401.m9RE1bQB012111>