Date: Sat, 15 Mar 2008 01:20:03 GMT From: bruce@cran.org.uk To: freebsd-bugs@FreeBSD.org Subject: Re: bin/71613: [PATCH] traceroute(8): cleanup of the usr.sbin/traceroute6 code Message-ID: <200803150120.m2F1K3tI076051@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/71613; it has been noted by GNATS. From: bruce@cran.org.uk To: bug-followup@freebsd.org Cc: dan@obluda.cz Subject: Re: bin/71613: [PATCH] traceroute(8): cleanup of the usr.sbin/traceroute6 code Date: Sat, 15 Mar 2008 01:15:44 +0000 --4Ckj6UjgE2iN1+kY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I'm not sure 'volatile' is correct in this case - string literals should be defined 'const' since they can't be changed. Doing this removes the warning about 'copyright' being unused. I've attached an updated patch. -- Bruce --4Ckj6UjgE2iN1+kY Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="traceroute6.c.diff" --- traceroute6.c.old 2008-03-15 01:07:03.000000000 +0000 +++ traceroute6.c 2008-03-15 01:07:36.000000000 +0000 @@ -66,7 +66,7 @@ */ #ifndef lint -static char copyright[] = +static const char copyright[] = "@(#) Copyright (c) 1990, 1993\n\ The Regents of the University of California. All rights reserved.\n"; #endif /* not lint */ --4Ckj6UjgE2iN1+kY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200803150120.m2F1K3tI076051>