Date: Thu, 27 May 2004 11:49:48 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: John Baldwin <jhb@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf files.i386 src/sys/i386/i386apic_vector.s exception.s src/sys/i386/isa atpic_vector.s Message-ID: <20040527114013.X8390@gamplex.bde.org> In-Reply-To: <200405261032.49453.jhb@FreeBSD.org> References: <200405260743.i4Q7hg3t059231@repoman.freebsd.org> <200405261032.49453.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 26 May 2004, John Baldwin wrote:
> On Wednesday 26 May 2004 03:43 am, Bruce Evans wrote:
> > bde 2004/05/26 00:43:41 PDT
> >
> > FreeBSD src repository
> >
> > Modified files:
> > sys/conf files.i386
> > sys/i386/i386 apic_vector.s exception.s
> > sys/i386/isa atpic_vector.s
> > Log:
> > MFamd64:
> >
> > Fixed profiling of trap, syscall and interrupt handlers and some
> > ordinary functions, essentially by backing out half of rev.1.106 of
> > i386/exception.s. The handlers must be between certain labels for
> > the purposes of profiling, and this was broken by scattering them in
> > separately compiled .s files, especially for ordinary functions that
> > ended up between the labels. Merge the files by #including them as
> > before, except with different pathnames and better comments and
> > organization. Changes to the scattered files are minimal -- just
> > move the labels to the file that does the #includes.
>
> Oh well, there will never be an apic.ko then.
Including files shouldn't affect modules, since they are only included
when the option is only configured as a module. apic.ko would just not
work right with profiling, the same as now. To work right, it would
somehow have to arrange that its symbols are correctly classified by
mcount(), perhaps by putting them in a special subsection of the text
section. Does kldload(2) support this? I can't see where it reads
ldscript.${MACHINE}.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040527114013.X8390>