Date: Thu, 21 Aug 2025 22:07:05 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: Enji Cooper <ngie@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 267f8c1f4b09 - main - crypto/openssl: make vendor imports easier/less error prone Message-ID: <39A8B2D8-49D9-4303-A74A-23FB38B867CC@freebsd.org> In-Reply-To: <202508211705.57LH50gR095150@gitrepo.freebsd.org> References: <202508211705.57LH50gR095150@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21 Aug 2025, at 18:05, Enji Cooper <ngie@freebsd.org> wrote: >=20 > The branch main has been updated by ngie: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D267f8c1f4b09431b335d5f48d8458604= 7471f978 >=20 > commit 267f8c1f4b09431b335d5f48d84586047471f978 > Author: Enji Cooper <ngie@FreeBSD.org> > AuthorDate: 2025-08-01 04:03:33 +0000 > Commit: Enji Cooper <ngie@FreeBSD.org> > CommitDate: 2025-08-21 17:02:46 +0000 >=20 > crypto/openssl: make vendor imports easier/less error prone >=20 > This change adds a custom BSD makefile containing multiple = high-level PHONY > targets, similar to targets provided by the ports framework. >=20 > The Makefile does the following: > - Reruns Configure with a deterministic set of arguments to ensure = that > all appropriate features have been enabled/disabled in OpenSSL. > - Preens the pkgconfig files to remove duplicate paths in their > `CFLAGS` and `includedir` variables. > - Rebuilds all ASM files to ensure that the content contained is = fresh. > - Rebuilds all manpages to ensure that the content contained in the > manpages is fresh. >=20 > Some additional work needs to be done to make the manpage = regeneration > "operation" reproducible (the date the manpages were generated is > embedded in the files). >=20 > All dynamic configuration previously captured in > `include/openssl/configuration.h` and `include/crypto/bn_conf.h` = has been > moved to `freebsd/include/dynamic_freebsd_configuration.h` and > `freebsd/include/crypto/bn_conf.h`, respectively. This helps > ensure that future updates don't wipe out FreeBSD customizations to > these files, which tune behavior on a per-target architecture = basis, e.g., > ARM vs x86, 32-bit vs 64-bit, etc. >=20 > MFC after: 1 month > Differential Revision: https://reviews.freebsd.org/D51663 Something in this breaks building on macOS (where, as of recently, we build libcrypto as a bootstrap library for use by the certctl bootstrap tool): = /Users/runner/work/freebsd-src/freebsd-src/crypto/openssl/crypto/bio/bio_s= ock2.c:64:9: error: call to undeclared function 'ktls_enable'; ISO C99 = and later do not support implicit function declarations = [-Wimplicit-function-declaration]=20 ktls_enable(sock);=20 ^=20 = /Users/runner/work/freebsd-src/freebsd-src/crypto/openssl/crypto/bio/bio_s= ock2.c:202:5: error: call to undeclared function 'ktls_enable'; ISO C99 = and later do not support implicit function declarations = [-Wimplicit-function-declaration]=20 ktls_enable(sock);=20 ^=20 2 errors generated.=20 --- bio_sock2.o ---=20 *** [bio_sock2.o] Error code 1 Presumably you need a BOOTSTRAPPING check somewhere. Jessica
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?39A8B2D8-49D9-4303-A74A-23FB38B867CC>