Date: Tue, 28 Oct 2014 16:52:17 +0100 From: "bapt@FreeBSD.org >> Baptiste Daroussin" <bapt@freebsd.org> To: Adam McDougall <mcdouga9@egr.msu.edu> Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r273782 - in head/usr.sbin/pw: . tests Message-ID: <20141028155217.GD26796@ivaldir.etoilebsd.net> In-Reply-To: <544FB7DA.8010502@egr.msu.edu> References: <201410281454.s9SEs5kb098825@svn.freebsd.org> <544FB7DA.8010502@egr.msu.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Oct 28, 2014 at 11:35:54AM -0400, Adam McDougall wrote: > On 10/28/2014 10:54, Baptiste Daroussin wrote: > > Author: bapt > > Date: Tue Oct 28 14:54:04 2014 > > New Revision: 273782 > > URL: https://svnweb.freebsd.org/changeset/base/273782 > > > > Log: > > Do not delete the group wheel when bad argument is passed to pw groupdel -g > > > > Check that the -g argument is actually a number, if not report an error. > > This argument is converted without checking with atoi(3) later so without this > > check it converts any alpha entries into 0 meaning it deletes the group wheel > > > > Add a regression test about it > > > > PR: 90114 > > Reported by: bkoenig@cs.tu-berlin.de > > MFC after: 1 week > > > > Modified: > > head/usr.sbin/pw/pw_group.c > > head/usr.sbin/pw/tests/pw_delete.sh > > Would you mind looking at this related pw bug with patch? Thanks. > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=187189 I will yes regards, Bapt [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlRPu7EACgkQ8kTtMUmk6EyTiwCeP9HMyETRBNJS8mgZ2hmFWnin 6zAAnRbBjiBnhBBnYHOmjPA/Vt+/qmN2 =tB46 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141028155217.GD26796>