Date: Sat, 09 Sep 2017 13:07:15 -0600 From: Ian Lepore <ian@freebsd.org> To: Sean Bruno <sbruno@freebsd.org>, Marcin Wojtas <mw@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323359 - in head/sys: conf dev/uart modules/uart Message-ID: <1504984035.32063.61.camel@freebsd.org> In-Reply-To: <2ace05fc-4dc9-494a-8e6f-27fa9f1ebf97@freebsd.org> References: <201709091142.v89BgX8e090592@repo.freebsd.org> <c25c2924-40a0-d5b3-43fe-8e83df185146@freebsd.org> <1504981201.32063.59.camel@freebsd.org> <2ace05fc-4dc9-494a-8e6f-27fa9f1ebf97@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2017-09-09 at 12:45 -0600, Sean Bruno wrote: >=20 > On 09/09/17 12:20, Ian Lepore wrote: > >=20 > > On Sat, 2017-09-09 at 12:09 -0600, Sean Bruno wrote: > > >=20 > > >=20 > > > On 09/09/17 05:42, Marcin Wojtas wrote: > > > >=20 > > > >=20 > > > > Author: mw > > > > Date: Sat Sep=A0=A09 11:42:32 2017 > > > > New Revision: 323359 > > > > URL: https://svnweb.freebsd.org/changeset/base/323359 > > > >=20 > > > > Log: > > > > =A0 Introduce UART driver module for Armada 3700 > > > > =A0=A0 > > > > =A0 This patch adds support for UART in Armada 3700 family. > > > > =A0 It exposes both low-level UART interface, as well as > > > > =A0 standard driver methods. > > > > =A0=A0 > > > > =A0 Submitted by: Patryk Duda <pdk@semihalf.com> > > > > =A0 Obtained from: Semihalf > > > > =A0 Sponsored by: Semihalf > > > > =A0 Differential Revision: https://reviews.freebsd.org/D12250 > > > >=20 > > > > Added: > > > > =A0 head/sys/dev/uart/uart_dev_mvebu.c=A0=A0=A0(contents, props > > > > changed) > > > > Modified: > > > > =A0 head/sys/conf/files > > > > =A0 head/sys/modules/uart/Makefile > > > Hrm ... I seem to be getting a compile failure after this: > > >=20 > > > cc -target x86_64-unknown-freebsd12.0 -- > > > sysroot=3D/var/tmp/usr/src/tmp > > > -B/var/tmp/usr/src/tmp/usr/bin=A0=A0-O2 -pipe=A0=A0-fno-strict-alia= sing > > > -Werror > > > -D_KERNEL -DKLD_MODULE -nostdinc=A0=A0=A0-DHAVE_KERNEL_OPTION_HEADE= RS > > > -include > > > /var/tmp/usr/src/sys/GENERIC-NODEBUG/opt_global.h -I. > > > -I/usr/src/sys > > > -fno-common -g -fno-omit-frame-pointer -mno-omit-leaf-frame- > > > pointer > > > -I/var/tmp/usr/src/sys/GENERIC-NODEBUG=A0=A0=A0-MD > > > -MF.depend.uart_dev_mvebu.o -MTuart_dev_mvebu.o -mcmodel=3Dkernel > > > -mno-red-zone -mno-mmx -mno-sse -msoft-float > > > -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack- > > > protector > > > -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict- > > > prototypes > > > -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef > > > -Wno-pointer-sign -D__printf__=3D__freebsd_kprintf__ > > > -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown- > > > pragmas > > > -Wno-error-tautological-compare -Wno-error-empty-body > > > -Wno-error-parentheses-equality -Wno-error-unused-function > > > -Wno-error-pointer-sign -Wno-error-shift-negative-value > > > -Wno-error-address-of-packed-member=A0=A0-mno-aes -mno-avx > > > -std=3Diso9899:1999 -c /usr/src/sys/dev/uart/uart_dev_mvebu.c -o > > > uart_dev_mvebu.o > > > In file included from /usr/src/sys/dev/uart/uart_dev_mvebu.c:39: > > > /usr/src/sys/dev/ofw/ofw_bus_subr.h:40:10: fatal error: > > > 'ofw_bus_if.h' > > > file not found > > > #include "ofw_bus_if.h" > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0^~~~~~~~~~~~~~ > > > 1 error generated. > > > *** Error code 1 > > >=20 > > > Is there supposed to be processing of ofw_bus_if.m somewhere that > > > is > > > currently missed? > > >=20 > > > sean > > >=20 > > ofw_bus_if.h needs to be added to SRCS=3D in the module > > makefile.=A0=A0Over > > the years I learned to grep the c files for _if.h to figure out > > what > > generated files to add to a module makefile, but ofw_bus_if.h is > > insidious -- it gets included from ofw_bus_subr.h so nobody > > includes it > > directly and it always gets missed in new module makefiles. > >=20 > > -- Ian > >=20 > >=20 > >=20 >=20 > Oh, the SRCS entry *is* in sys/modules/uart/Makefile but not for x86 > archs.=A0=A0Should this even be built for x86? >=20 > sean >=20 No, this driver is specific to Marvell arm systems. =A0Mostly, arm uart drivers don't get listed in modules/uart becuase they're compiled in as console drivers. =A0A few arm systems have video consoles and uart as a module might have more value. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1504984035.32063.61.camel>