Date: Mon, 25 Jul 2005 21:30:27 GMT From: Victor Cruceru <soc-victor@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 80987 for review Message-ID: <200507252130.j6PLURu7064806@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=80987 Change 80987 by soc-victor@soc-victor_82.76.158.176 on 2005/07/25 21:29:50 A matter of style: use the special purpose (already defined) oid_zeroDotZero variable instead hardcoded values all over the HOST RESOURCES code. Affected files ... .. //depot/projects/soc2005/bsnmp/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_device_tbl.c#4 edit .. //depot/projects/soc2005/bsnmp/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_processor_tbl.c#2 edit .. //depot/projects/soc2005/bsnmp/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_swrun_tbl.c#5 edit Differences ... ==== //depot/projects/soc2005/bsnmp/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_device_tbl.c#4 (text+ko) ==== @@ -225,7 +225,7 @@ } - entry->id = (struct asn_oid){2,{0,0,}}; /*unknown id - FIX ME*/ + entry->id = oid_zeroDotZero; /*unknown id - FIX ME*/ entry->status = hrDevice_getStatus(dev); ==== //depot/projects/soc2005/bsnmp/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_processor_tbl.c#2 (text+ko) ==== @@ -174,7 +174,7 @@ entry->load = 0; entry->cpu_no = (u_char)cpu_no; entry->idle_pid = 0; - entry->frwId = (struct asn_oid){2,{0,0,}}; /*unknown id - FIX ME*/ + entry->frwId = oid_zeroDotZero; /*unknown id - FIX ME*/ INSERT_OBJECT_INT(entry, &hrState_g.hr_processor_tbl); hrState_g.detected_processor_count++; ==== //depot/projects/soc2005/bsnmp/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_swrun_tbl.c#5 (text+ko) ==== @@ -159,7 +159,7 @@ entry->name[sizeof(entry->name) - 1] = '\0'; (void)strncpy(&entry->name[0], &kp->ki_ocomm[0], sizeof(entry->name) - 1); - entry->id = (struct asn_oid){2,{0,0,}}; /*unknown id - FIX ME*/ + entry->id = oid_zeroDotZero; /*unknown id - FIX ME*/ entry->path[0] = '\0'; entry->parameters[0] = '\0'; @@ -224,7 +224,7 @@ /*no parameters for kernel files (.ko) of for the kernel*/ entry->parameters[0] = '\0'; - entry->id = (struct asn_oid){2,{0,0,}}; /*unknown id - FIX ME*/ + entry->id = oid_zeroDotZero; /*unknown id - FIX ME*/ if (strncmp(kfs->name, "kernel", strlen("kernel") ) == 0) { entry->type = SRT_OPERATING_SYSTEM;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200507252130.j6PLURu7064806>