Date: Wed, 16 Mar 2016 21:04:57 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: NGie Cooper <yaneurabeya@gmail.com> Cc: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>, <sjg@juniper.net> Subject: Re: svn commit: r296970 - head/lib/libxo/tests Message-ID: <85789.1458187497@kaos.jnpr.net> In-Reply-To: <984878F0-9CE9-442D-8F7F-40C5365052AA@gmail.com> References: <201603170037.u2H0b4Rb082849@repo.freebsd.org> <984878F0-9CE9-442D-8F7F-40C5365052AA@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
NGie Cooper <yaneurabeya@gmail.com> wrote:
> > SUBDIR+= encoder
> >
> > +.if ${MACHINE} == "host"
> > +# make it easy to test without install
> > +TESTSDIR= ${.OBJDIR}
> > +CFLAGS+= -I${.CURDIR:H}
> > +.endif
> > +
> > .include <bsd.test.mk>
>
> This commit seems unnecessary -- have you tried make check yet?
That appears to require installing things before you test that they
work - seems a bit backwards?
Note the above is only relevant when building with DIRDEPS.
Where we want to be able to build and run relevant tests as part of the
build as we go - when MACHINE = "host" that is.
Phil wants to fix this so that it runs all his test suite properly and
also need to arrange to auto-update the makefile here as new tests are
added to the distribution.
Probably need somthing like bmake's after-import target.
Anyway, being able to have this work in context of DIRDEPS_BUILD will
help (I haven't added the MK_TESTS hooks yet).
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?85789.1458187497>