Date: Tue, 16 Nov 2010 09:52:56 -0800 From: Garrett Cooper <gcooper@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: Bruce Cran <bruce@cran.org.uk>, freebsd-hackers@freebsd.org, Adrian Chadd <adrian@freebsd.org>, "Andrey V. Elsukov" <bu7cher@yandex.ru>, freebsd-current@freebsd.org Subject: Re: breaking the crunchgen logic into a share/mk file Message-ID: <AANLkTinsh3_bZW93N0m7JQP5nDF%2B0T9Dh4uWYP4p1T4u@mail.gmail.com> In-Reply-To: <201011160912.27693.jhb@freebsd.org> References: <AANLkTi=BwHge47xnQa39cERXhoTnFGW0HqCYkHLgnnbQ@mail.gmail.com> <201011160829.13511.jhb@freebsd.org> <4CE28AE4.70101@yandex.ru> <201011160912.27693.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Nov 16, 2010 at 6:12 AM, John Baldwin <jhb@freebsd.org> wrote: > On Tuesday, November 16, 2010 8:45:08 am Andrey V. Elsukov wrote: >> On 16.11.2010 16:29, John Baldwin wrote: >> > Err, are there no longer hard links to all of the frontends for a given >> > crunch? If so, that is a problem as it will make rescue much harder to use. >> >> Yes, probably this patch is not needed and it should be fixed somewhere in >> makefiles. But currently rescue does not have any hardlinks: >> http://pub.allbsd.org/FreeBSD-snapshots/i386-i386/9.0-HEAD-20101116-JPSNAP/cdrom/livefs/rescue/ >> >> And what is was before: >> http://pub.allbsd.org/FreeBSD-snapshots/i386-i386/9.0-HEAD-20101112-JPSNAP/cdrom/livefs/rescue/ > > That definitely needs to be fixed. The .mk file wasn't being installed. Could someone please test this patch for validity and commit it? More importantly, why didn't the above build process, or tinderbox fail properly with this change? Thanks, -Garrett [-- Attachment #2 --] Index: share/mk/Makefile =================================================================== --- share/mk/Makefile (revision 215333) +++ share/mk/Makefile (working copy) @@ -3,7 +3,8 @@ FILES= bsd.README FILES+= bsd.arch.inc.mk -FILES+= bsd.compat.mk bsd.cpu.mk bsd.dep.mk bsd.doc.mk bsd.dtrace.mk +FILES+= bsd.compat.mk bsd.crunchgen.mk bsd.cpu.mk +FILES+= bsd.dep.mk bsd.doc.mk bsd.dtrace.mk FILES+= bsd.endian.mk FILES+= bsd.files.mk bsd.incs.mk bsd.info.mk bsd.init.mk FILES+= bsd.kmod.mk
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTinsh3_bZW93N0m7JQP5nDF%2B0T9Dh4uWYP4p1T4u>