Date: Sun, 2 Mar 2014 16:31:59 -0500 From: Julio Merino <jmmv@freebsd.org> To: Garrett Cooper <yanegomi@gmail.com> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, Pawel Jakub Dawidek <pjd@freebsd.org> Subject: Re: [PATCH] Integrate pjdfstest into the build Message-ID: <CAFY7cWDsR=82ANK8q2-SoVyu6BowdC6hHDwo%2Bs1P7Jt%2Bfy8ZCQ@mail.gmail.com> In-Reply-To: <94D3F60A-1E12-418B-8313-E43C93878B95@gmail.com> References: <94D3F60A-1E12-418B-8313-E43C93878B95@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 27, 2014 at 5:41 AM, Garrett Cooper <yanegomi@gmail.com> wrote: > Hi all, > The attached patch integrates pjdfstest into the build. It also simplifies some logic in tests/sys/Makefile when copying Kyuafile. Aaand one more time, apologies for the delay. I think I'm caught up now! * What's the point of PJDFSTEST_I_KNOW_WHAT_I_AM_DOING? *Why* is it a very bad idea to do so? * The 'tests' path component in pjdfstest/tests/ should go away; it is redundant. * Add $FreeBSD$ tags everywhere where missing. * The test files should move from tools/regression/pjdfstest/ into the new location under tests/sys/ and be renamed to follow the conventions under src/test (e.g. xx.t -> xx_test). Cheers
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFY7cWDsR=82ANK8q2-SoVyu6BowdC6hHDwo%2Bs1P7Jt%2Bfy8ZCQ>